mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] PCI changes (link error)
Date: Fri, 14 Jan 2011 23:01:09 +0100	[thread overview]
Message-ID: <201101142301.09624.rjw@sisk.pl> (raw)
In-Reply-To: <20110114193731.GA2381@gentoo.trippels.de>

On Friday, January 14, 2011, Markus Trippelsdorf wrote:
> On 2011.01.14 at 09:01 -0800, Jesse Barnes wrote:
> > ...
> > 
> > Rafael J. Wysocki (5):
> >       PCI hotplug: Fix unexpected driver unregister in pciehp_acpi.c
> >       PCI/PCIe: Clear Root PME Status bits early during system resume
> >       PCI/ACPI: Request _OSC control once for each root bridge (v3)
> 
> This breaks the build if CONFIG_PCIEPORTBUS is not set:
> 
> ld: drivers/built-in.o: in function acpi_pci_root_add:pci_root.c(.devinit.text+0x2633): error: undefined reference to 'pcie_ports_disabled'

Does the appended patch help?

Rafael

---
 include/linux/pci.h |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux-2.6/include/linux/pci.h
===================================================================
--- linux-2.6.orig/include/linux/pci.h
+++ linux-2.6/include/linux/pci.h
@@ -993,8 +993,13 @@ extern void pci_restore_msi_state(struct
 extern int pci_msi_enabled(void);
 #endif
 
+#ifdef CONFIG_PCIEPORTBUS
 extern bool pcie_ports_disabled;
 extern bool pcie_ports_auto;
+#else
+#define pcie_ports_disabled	true
+#define bool pcie_ports_auto	false
+#endif
 
 #ifndef CONFIG_PCIEASPM
 static inline int pcie_aspm_enabled(void)

  reply	other threads:[~2011-01-14 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 17:01 [git pull] PCI changes Jesse Barnes
2011-01-14 19:37 ` [git pull] PCI changes (link error) Markus Trippelsdorf
2011-01-14 22:01   ` Rafael J. Wysocki [this message]
2011-01-14 22:13     ` Markus Trippelsdorf
2011-01-14 22:15       ` Jesse Barnes
2011-01-14 23:07         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101142301.09624.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®