From: Shreyas N Bhatewara <sbhatewara@vmware.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: pv-drivers@vmware.com, Guolin Yang <gyang@vmware.com>
Subject: [PATCH net-next 3/8] vmxnet3: Enable HW Rx VLAN stripping by default
Date: Fri, 14 Jan 2011 16:59:36 -0800 [thread overview]
Message-ID: <20110115005936.1064.46582.stgit@sbhatewara-dev1.eng.vmware.com> (raw)
In-Reply-To: <20110115005701.1064.67435.stgit@sbhatewara-dev1.eng.vmware.com>
Make hw vlan tag stripping as enabled by default. Thereby remove
the code to conditionally enable it later.
Signed-off-by: Guolin Yang <gyang@vmware.com>
Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 14 +-------------
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 89bcee8..f47db1c 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1867,13 +1867,8 @@ vmxnet3_vlan_rx_register(struct net_device *netdev, struct vlan_group *grp)
/* add vlan rx stripping. */
if (adapter->netdev->features & NETIF_F_HW_VLAN_RX) {
int i;
- struct Vmxnet3_DSDevRead *devRead = &shared->devRead;
adapter->vlan_grp = grp;
- /* update FEATURES to device */
- devRead->misc.uptFeatures |= UPT1_F_RXVLAN;
- VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
- VMXNET3_CMD_UPDATE_FEATURE);
/*
* Clear entire vfTable; then enable untagged pkts.
* Note: setting one entry in vfTable to non-zero turns
@@ -1905,11 +1900,6 @@ vmxnet3_vlan_rx_register(struct net_device *netdev, struct vlan_group *grp)
}
VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
VMXNET3_CMD_UPDATE_VLAN_FILTERS);
-
- /* update FEATURES to device */
- devRead->misc.uptFeatures &= ~UPT1_F_RXVLAN;
- VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
- VMXNET3_CMD_UPDATE_FEATURE);
}
}
}
@@ -2083,10 +2073,8 @@ vmxnet3_setup_driver_shared(struct vmxnet3_adapter *adapter)
devRead->misc.uptFeatures |= UPT1_F_LRO;
devRead->misc.maxNumRxSG = cpu_to_le16(1 + MAX_SKB_FRAGS);
}
- if ((adapter->netdev->features & NETIF_F_HW_VLAN_RX) &&
- adapter->vlan_grp) {
+ if (adapter->netdev->features & NETIF_F_HW_VLAN_RX)
devRead->misc.uptFeatures |= UPT1_F_RXVLAN;
- }
devRead->misc.mtu = cpu_to_le32(adapter->netdev->mtu);
devRead->misc.queueDescPA = cpu_to_le64(adapter->queue_desc_pa);
next prev parent reply other threads:[~2011-01-15 0:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 0:59 [PATCH net-next 0/8] vmxnet3 fixes and enhancements Shreyas N Bhatewara
2011-01-15 0:59 ` [PATCH net-next 1/8] vmxnet3: fix ring size update Shreyas N Bhatewara
2011-01-15 0:59 ` [PATCH net-next 2/8] vmxnet3: Preserve the MAC address configured by ifconfig Shreyas N Bhatewara
2011-01-15 0:59 ` Shreyas N Bhatewara [this message]
2011-01-15 0:59 ` [PATCH net-next 4/8] vmxnet3: Provide required number of bytes in first SG buffer Shreyas N Bhatewara
2011-01-15 0:59 ` [PATCH net-next 5/8] vmxnet3: Make ethtool handlers multiqueue aware Shreyas N Bhatewara
2011-01-18 16:05 ` Ben Hutchings
2011-01-15 0:59 ` [PATCH net-next 6/8] vmxnet3: Disable napi in suspend, reenable in resume Shreyas N Bhatewara
2011-01-15 0:59 ` [PATCH net-next 7/8] vmxnet3: Add locking for access to command register Shreyas N Bhatewara
2011-01-15 1:00 ` [PATCH net-next 8/8] vmxnet3: Dont allocate extra MSI-x vectors Shreyas N Bhatewara
2011-01-16 5:21 ` [PATCH net-next 0/8] vmxnet3 fixes and enhancements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115005936.1064.46582.stgit@sbhatewara-dev1.eng.vmware.com \
--to=sbhatewara@vmware.com \
--cc=gyang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®