From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397Ab1AOLIw (ORCPT ); Sat, 15 Jan 2011 06:08:52 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:49905 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169Ab1AOLIu (ORCPT ); Sat, 15 Jan 2011 06:08:50 -0500 Date: Sat, 15 Jan 2011 11:08:48 +0000 From: Al Viro To: sedat.dilek@gmail.com Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-fsdevel Subject: Re: linux-next: Tree for January 15 (Call Trace in fs/dcache.c + autofs4) Message-ID: <20110115110848.GL19804@ZenIV.linux.org.uk> References: <20110115075723.GJ19804@ZenIV.linux.org.uk> <20110115090702.GK19804@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2011 at 12:00:54PM +0100, Sedat Dilek wrote: > > Argh... ??In __do_follow_link() replace > > > > ?? ?? ?? ??if (link->mnt != nd->path.mnt) > > with > > ?? ?? ?? ??if (link->mnt == nd->path.mnt) > > > > Mismerge yesterday ;-/ ??I've pushed fix for that in for-next, will fold > > shortly. ??As for autofs4 breakage, I've a preliminary fix, testing it > > now. > > > > Hey, cool and thanks. > > Not sure if you catched them all, I have noticed on my latest > ("buggy") linux-next kernel these Call Traces when doing an > update-grub. That might be vfsmount being dropped when it shouldn't or dentry leaked. And seeing that it's umount(8), I would suspect the latter... Anyway, with the latest from dhowells we probably should have d_set_d_op() mess on autofs4 under control (in #for-next). Whether it's enough to actually fix the sucker is a separate question, of course - there might very well be more crap. I've instrumented mntput() et.al. here; hopefully that'll make catching the remaining turds easier. As for dcache leaks... ouch. Could you try to reproduce that one on the mainline kernel? At least that'd isolate things a bit.