From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442Ab1ARJiv (ORCPT ); Tue, 18 Jan 2011 04:38:51 -0500 Received: from adelie.canonical.com ([91.189.90.139]:47476 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283Ab1ARJiu (ORCPT ); Tue, 18 Jan 2011 04:38:50 -0500 Date: Tue, 18 Jan 2011 09:38:44 +0000 From: Andy Whitcroft To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] sysrq is half-enabled by default Message-ID: <20110118093844.GH16804@shadowen.org> References: <1295123037-2649-1-git-send-email-apw@canonical.com> <20110115215450.GB19872@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110115215450.GB19872@core.coreip.homeip.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2011 at 01:54:50PM -0800, Dmitry Torokhov wrote: > Hi Andy, > > On Sat, Jan 15, 2011 at 08:23:56PM +0000, Andy Whitcroft wrote: > > It seems that recent cleanups to sysrq handling have lead to us having > > two copies of the sysrq enable status. At boot these are currently > > inconsistently specified leading to sysrq actually being enabled but > > reported as not enabled in sysfs. Following this email is a patch to > > link both of these copies to a common configuration setting. > > > > Thanks for noticing this, but I do not think we need a new configuration > parameter. We did not have it for about 10 years and distributions know > how to disable it upon boot if they want to. > > Do youthink you could cange the patch and add a default value (1) to > inlude/linux/sysrq.h and use it in sysctl and the handler code? Sure thing. -apw