From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Ram Pai <linuxram@us.ibm.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
clemens@ladisch.de, Yinghai Lu <yinghai@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
peter.henriksson@gmail.com, ebiederm@aristanetworks.com
Subject: Re: [PATCH 1/1] PCI: allocate essential resources before reserving hotplug resources
Date: Tue, 18 Jan 2011 15:11:14 -0700 [thread overview]
Message-ID: <201101181511.16343.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20110118214253.GA10069@ram-laptop>
On Tuesday, January 18, 2011 02:42:53 pm Ram Pai wrote:
> On Tue, Jan 18, 2011 at 01:52:06PM -0700, Bjorn Helgaas wrote:
> > This is a PCI-specific issue, so I'm not comfortable adding add_size
> > to struct resource. That penalizes all resource users while only
> > helping PCI. Also, the struct resource lives forever, and the
> > add_size information is only useful while we're configuring the
> > bridge.
>
> Any suggestion on how to do this without adding a field to struct resource?
It *is* a little ugly. You compute some of this info early, in
pbus_size_io/mem(), but it's not used until later. Maybe it would
make sense in struct pci_bus? That's a pain, too, because then you
have to test the resource type in adjust_resources_sorted() but at
least it's a per-PCI bridge structure.
Bjorn
next prev parent reply other threads:[~2011-01-18 22:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 22:58 [RFC v2 PATCH 1/1] PCI: override BIOS/firmware resource allocation Ram Pai
2010-10-06 23:39 ` Bjorn Helgaas
2010-10-07 0:30 ` Ram Pai
2010-10-07 4:13 ` Bjorn Helgaas
2010-10-07 20:42 ` Ram Pai
2010-10-07 21:41 ` Bjorn Helgaas
2010-10-08 17:32 ` Ram Pai
2010-10-08 20:16 ` Bjorn Helgaas
2010-10-12 7:05 ` Ram Pai
2010-10-12 19:01 ` Bjorn Helgaas
2010-10-18 20:10 ` Jesse Barnes
2010-10-19 17:17 ` Ram Pai
2010-10-19 18:24 ` Jesse Barnes
2010-10-22 0:28 ` Ram Pai
2010-10-22 17:55 ` Bjorn Helgaas
2010-10-22 18:59 ` Ram Pai
2010-10-22 21:49 ` Bjorn Helgaas
2010-10-22 17:16 ` [PATCH 1/1] PCI: ignore failure to preallocate minimal resources to hotplug bridges Ram Pai
2010-10-22 22:16 ` Bjorn Helgaas
2011-01-07 22:32 ` Jesse Barnes
2011-01-11 21:10 ` Ram Pai
2011-01-14 18:19 ` [PATCH 1/1] PCI: allocate essential resources before reserving hotplug resources Ram Pai
2011-01-18 20:52 ` Bjorn Helgaas
2011-01-18 21:42 ` Ram Pai
2011-01-18 22:11 ` Bjorn Helgaas [this message]
2011-01-19 19:58 ` [PATCH 1/1 v3] " Ram Pai
2011-01-20 1:00 ` [PATCH 1/1 v4] " Ram Pai
2011-01-21 1:22 ` Yinghai Lu
2011-01-21 7:17 ` Ram Pai
2011-01-18 21:30 ` [PATCH 1/1 Version 2.0] " Ram Pai
2011-01-18 21:46 ` Bjorn Helgaas
2011-01-18 22:03 ` Ram Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101181511.16343.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=clemens@ladisch.de \
--cc=ebiederm@aristanetworks.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=peter.henriksson@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®