From: Felipe Balbi <balbi@ti.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: balbi@ti.com, Yang Ruirui <ruirui.r.yang@tieto.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Felipe Balbi <felipe.balbi@nokia.com>,
Heikki Krogerus <ext-heikki.krogerus@nokia.com>,
Tejun Heo <tj@kernel.org>, Samuel Ortiz <sameo@linux.intel.com>,
Hema HK <hemahk@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb otg: use atomic notifier instead of blocking notifier
Date: Wed, 19 Jan 2011 18:01:02 +0200 [thread overview]
Message-ID: <20110119160102.GA4629@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <AANLkTinV4afVtBfrRoW_UgLyvHpANZWp4P_yzah=WYUc@mail.gmail.com>
On Wed, Jan 19, 2011 at 11:38:44PM +0800, Ming Lei wrote:
> Hi,
>
> 2011/1/19 Felipe Balbi <balbi@ti.com>:
>
> > that's easy to guess since commit log says it's a problem on Meego
> > kernel.
>
> OK, it is a specific issue on Meego kernel, so it is better to add
> "Meego " in the patch title.
>
> >
> >> Are you sure the issue can be reproduced in 2.6.37 or -next tree?
> >>
> >> In mainline code(2.6.37), blocking_notifier_call_chain is only called in
> >> threaded irq handler of otg driver wrt. musb driver, so seems enough.
> >
> > true, but seems like Nokia is using to notify gadget states, which makes
> > a lot of sense when you start thinking about things such as battery
> > charging.
>
> Please go ahead to submit and merge it into mainline first if it makes
> sense, :-)
isn't it what his patch is already intending to do ? Or do you want them
to send the initial buggy version and only afterwards send the bugfix ?
A bit weird decision wouldn't that be ?
--
balbi
next prev parent reply other threads:[~2011-01-19 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 9:20 Yang Ruirui
2011-01-19 10:33 ` Heikki Krogerus
2011-01-21 15:34 ` Grazvydas Ignotas
2011-01-19 10:40 ` Felipe Balbi
2011-01-20 2:06 ` Yang Ruirui
2011-01-20 4:01 ` Felipe Balbi
2011-01-19 15:18 ` Ming Lei
2011-01-19 15:30 ` Felipe Balbi
2011-01-19 15:38 ` Ming Lei
2011-01-19 16:01 ` Felipe Balbi [this message]
2011-01-20 15:51 ` Mian Yousaf Kaukab
2011-01-19 9:22 Yang Ruirui
2011-01-19 9:19 ` Dave Young
2011-01-20 6:46 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119160102.GA4629@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=ext-heikki.krogerus@nokia.com \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=hemahk@ti.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mian.yousaf.kaukab@stericsson.com \
--cc=ruirui.r.yang@tieto.com \
--cc=sameo@linux.intel.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®