From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Trilok Soni <tsoni@codeaurora.org>
Cc: riyer@nvidia.com, pavel@ucw.cz, shubhrajyoti@ti.com,
ccross@android.com, konkers@android.com, olof@lixom.net,
achew@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7] input: tegra-kbc - Add tegra keyboard driver
Date: Wed, 19 Jan 2011 23:29:48 -0800 [thread overview]
Message-ID: <20110120072948.GA30522@core.coreip.homeip.net> (raw)
In-Reply-To: <4D37E265.9060304@codeaurora.org>
On Thu, Jan 20, 2011 at 12:51:09PM +0530, Trilok Soni wrote:
> Hi Rakesh,
>
> On 1/20/2011 6:41 AM, riyer@nvidia.com wrote:
> > From: Rakesh Iyer <riyer@nvidia.com>
> >
> > This patch adds support for the internal matrix keyboard controller for
> > Nvidia Tegra platforms.
> >
> > Signed-off-by: Rakesh Iyer <riyer@nvidia.com>
> > ---
> > Fixed the stupid loop variable change.
> > Fixed some code styling problems reported by checkpatch.pl.
> >
>
> Thanks a ton for creating quick revisions :)
>
> > arch/arm/mach-tegra/include/mach/kbc.h | 61 +++
> > drivers/input/keyboard/Kconfig | 10 +
> > drivers/input/keyboard/Makefile | 1 +
> > drivers/input/keyboard/tegra-kbc.c | 727 ++++++++++++++++++++++++++++++++
> > 4 files changed, 799 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-tegra/include/mach/kbc.h
> > create mode 100644 drivers/input/keyboard/tegra-kbc.c
> >
> > diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h
> > new file mode 100644
> > index 0000000..60d646c
> > --- /dev/null
> > +++ b/arch/arm/mach-tegra/include/mach/kbc.h
> > @@ -0,0 +1,61 @@
> > +/*
> > + * Platform definitions for tegra-kbc keyboard input driver
> > + *
> > + * Copyright (c) 2010, NVIDIA Corporation.
>
> Wearing my legal hat. You might want to do 2010-2011 ?
OK, Rakesh, if you want copyright adjusted please shout and I can fix it
up locally.
Trilok, I understand you are happy, right? Can I put you down as
reviewed-by?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-01-20 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 1:11 riyer
2011-01-20 7:21 ` Trilok Soni
2011-01-20 7:29 ` Dmitry Torokhov [this message]
2011-01-20 7:33 ` Trilok Soni
2011-01-20 7:42 ` Dmitry Torokhov
2011-01-20 17:55 ` Rakesh Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120072948.GA30522@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=achew@nvidia.com \
--cc=ccross@android.com \
--cc=konkers@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pavel@ucw.cz \
--cc=riyer@nvidia.com \
--cc=shubhrajyoti@ti.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®