From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753908Ab1AUHr6 (ORCPT ); Fri, 21 Jan 2011 02:47:58 -0500 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:39040 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389Ab1AUHr5 (ORCPT ); Fri, 21 Jan 2011 02:47:57 -0500 Date: Fri, 21 Jan 2011 16:45:30 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "hannes@cmpxchg.org" , "balbir@linux.vnet.ibm.com" , "akpm@linux-foundation.org" , Daisuke Nishimura Subject: Re: [PATCH 3/7] memcg : fix mem_cgroup_check_under_limit Message-Id: <20110121164530.4cf9d01f.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20110121154141.680c96d9.kamezawa.hiroyu@jp.fujitsu.com> References: <20110121153431.191134dd.kamezawa.hiroyu@jp.fujitsu.com> <20110121154141.680c96d9.kamezawa.hiroyu@jp.fujitsu.com> Organization: NEC Soft, Ltd. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jan 2011 15:41:41 +0900 KAMEZAWA Hiroyuki wrote: > From: KAMEZAWA Hiroyuki > > Current memory cgroup's code tends to assume page_size == PAGE_SIZE > but THP does HPAGE_SIZE charge. > > This is one of fixes for supporing THP. This modifies > mem_cgroup_check_under_limit to take page_size into account. > > Total fixes for do_charge()/reclaim memory will follow this patch. > > TODO: By this reclaim function can get page_size as argument. > So...there may be something should be improvoed. > > Signed-off-by: KAMEZAWA Hiroyuki Acked-by: Daisuke Nishimura