mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Use cachable mapping for i915 opregion.
Date: Sun, 23 Jan 2011 21:52:27 +0100	[thread overview]
Message-ID: <201101232152.27970.rjw@sisk.pl> (raw)
In-Reply-To: <0d30dc$kr9u7e@orsmga001.jf.intel.com>

On Sunday, January 23, 2011, Chris Wilson wrote:
> On Sun, 23 Jan 2011 18:23:34 +0100, Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> wrote:
> > The opregion is a shared memory region between ACPI and the graphics
> > driver. As the ACPI mapping has been changed to cachable in commit
> > 6d5bbf00d251cc73223a71422d69e069dc2e0b8d, mapping the intel opregion
> > non-cachable now fails. As no bus-master hardware is involved in the
> > opregion, cachable map should do no harm.
> 
> Satisfied myself that is indeed equivalent to use the newly introduced
> acpi_os_ioremap for this purpose and applied to -fixes.

However, it might be better to use acpi_os_ioremap() in case we decide to
go back to ioremap() for some reason.  For now, ioremap_cache() seems fine,
but ...

Thanks,
Rafael

  reply	other threads:[~2011-01-23 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-23 17:23 Michael Karcher
2011-01-23 18:45 ` Chris Wilson
2011-01-23 20:52   ` Rafael J. Wysocki [this message]
2011-01-23 20:58     ` Chris Wilson
2011-01-23 21:35       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101232152.27970.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@mkarcher.dialup.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®