From: Jean Delvare <khali@linux-fr.org>
To: Bernhard Walle <walle@corscience.de>
Cc: ben-linux@fluff.org, ddaney@caviumnetworks.com,
ralf@linux-mips.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: octeon: Make the timeout independent of CONFIG_HZ
Date: Mon, 24 Jan 2011 15:00:05 +0100 [thread overview]
Message-ID: <20110124150005.577b0235@endymion.delvare> (raw)
In-Reply-To: <1295872826-22129-1-git-send-email-walle@corscience.de>
On Mon, 24 Jan 2011 13:40:26 +0100, Bernhard Walle wrote:
> Since the timeout in the struct i2c_adapter use jiffies as unit and a
> timeout should be independent of CONFIG_HZ, use a value of HZ/50 which
> is equal to the current value 2 for CONFIG_HZ=100.
>
> Signed-off-by: Bernhard Walle <walle@corscience.de>
Acked-by: Jean Delvare <khali@linux-fr.org>
Ben, please apply.
> ---
> drivers/i2c/busses/i2c-octeon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
> index 4cffda5..d07e5c7 100644
> --- a/drivers/i2c/busses/i2c-octeon.c
> +++ b/drivers/i2c/busses/i2c-octeon.c
> @@ -469,7 +469,7 @@ static struct i2c_adapter octeon_i2c_ops = {
> .owner = THIS_MODULE,
> .name = "OCTEON adapter",
> .algo = &octeon_i2c_algo,
> - .timeout = 2,
> + .timeout = HZ/50,
> };
>
> /**
--
Jean Delvare
next prev parent reply other threads:[~2011-01-24 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:05 [PATCH] i2c: octeon: Make the timeout 1*HZ instead of 1 jiffy Bernhard Walle
2011-01-24 12:14 ` Jean Delvare
2011-01-24 12:37 ` Bernhard Walle
2011-01-24 12:40 ` [PATCH] i2c: octeon: Make the timeout independent of CONFIG_HZ Bernhard Walle
2011-01-24 14:00 ` Jean Delvare [this message]
2011-03-16 13:32 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124150005.577b0235@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux@fluff.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=walle@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®