From: Tejun Heo <tj@kernel.org>
To: Greg Kroah-Hartman <greg@kroah.com>, Greg Ungerer <gerg@uclinux.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 68328serial: remove unsed m68k_serial->tqueue_hangup
Date: Mon, 24 Jan 2011 17:53:41 +0100 [thread overview]
Message-ID: <20110124165341.GE27510@htj.dyndns.org> (raw)
m68k_serial->tqueue_hangup is unused. Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Greg Ungerer <gerg@uclinux.org>
Cc: Greg Kroah-Hartman <greg@kroah.com>
---
drivers/tty/serial/68328serial.c | 23 -----------------------
drivers/tty/serial/68328serial.h | 1 -
2 files changed, 24 deletions(-)
Index: work/drivers/tty/serial/68328serial.c
===================================================================
--- work.orig/drivers/tty/serial/68328serial.c
+++ work/drivers/tty/serial/68328serial.c
@@ -393,28 +393,6 @@ static void do_softint(struct work_struc
#endif
}
-/*
- * This routine is called from the scheduler tqueue when the interrupt
- * routine has signalled that a hangup has occurred. The path of
- * hangup processing is:
- *
- * serial interrupt routine -> (scheduler tqueue) ->
- * do_serial_hangup() -> tty->hangup() -> rs_hangup()
- *
- */
-static void do_serial_hangup(struct work_struct *work)
-{
- struct m68k_serial *info = container_of(work, struct m68k_serial, tqueue_hangup);
- struct tty_struct *tty;
-
- tty = info->port.tty;
- if (!tty)
- return;
-
- tty_hangup(tty);
-}
-
-
static int startup(struct m68k_serial * info)
{
m68328_uart *uart = &uart_addr[info->line];
@@ -1348,7 +1326,6 @@ rs68328_init(void)
info->count = 0;
info->blocked_open = 0;
INIT_WORK(&info->tqueue, do_softint);
- INIT_WORK(&info->tqueue_hangup, do_serial_hangup);
init_waitqueue_head(&info->open_wait);
init_waitqueue_head(&info->close_wait);
info->line = i;
Index: work/drivers/tty/serial/68328serial.h
===================================================================
--- work.orig/drivers/tty/serial/68328serial.h
+++ work/drivers/tty/serial/68328serial.h
@@ -159,7 +159,6 @@ struct m68k_serial {
int xmit_tail;
int xmit_cnt;
struct work_struct tqueue;
- struct work_struct tqueue_hangup;
wait_queue_head_t open_wait;
wait_queue_head_t close_wait;
};
next reply other threads:[~2011-01-24 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 16:53 Tejun Heo [this message]
2011-01-24 17:56 ` Alan Cox
2011-01-25 11:08 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124165341.GE27510@htj.dyndns.org \
--to=tj@kernel.org \
--cc=gerg@uclinux.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®