From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: thomas@wytron.com.tw, linux-kernel@vger.kernel.org,
nios2-dev@sopc.et.ntust.edu.tw,
devicetree-discuss@lists.ozlabs.org, nico@fluxnic.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v4] smc91x: add devicetree support
Date: Tue, 25 Jan 2011 22:42:09 -0800 (PST) [thread overview]
Message-ID: <20110125.224209.183055030.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTindbigYzY0zJufpr-D25m_B5Gjqp09ZbcaN-aZ9@mail.gmail.com>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Tue, 25 Jan 2011 22:52:36 -0700
> On Tue, Jan 25, 2011 at 10:22 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
>> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
>> ---
>> v2 specify part numbers in compat as Grant suggested.
>> v3 more specific part name.
>> v4 include match table only for OF as David suggested.
>>
>> drivers/net/smc91x.c | 13 +++++++++++++
>> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> Looks okay to me.
>
> Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
Applied to net-next-2.6, thanks.
next prev parent reply other threads:[~2011-01-26 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 5:59 [PATCH] " Thomas Chou
2011-01-25 6:24 ` Grant Likely
2011-01-25 7:09 ` [PATCH v2] " Thomas Chou
2011-01-25 12:11 ` [PATCH v3] " Thomas Chou
2011-01-26 3:45 ` David Miller
2011-01-26 5:22 ` [PATCH v4] " Thomas Chou
2011-01-26 5:52 ` Grant Likely
2011-01-26 6:42 ` David Miller [this message]
2011-01-26 15:17 ` Nicolas Pitre
2011-01-26 15:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125.224209.183055030.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=nios2-dev@sopc.et.ntust.edu.tw \
--cc=thomas@wytron.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®