From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768Ab1AYFb1 (ORCPT ); Tue, 25 Jan 2011 00:31:27 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:58359 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950Ab1AYFbZ (ORCPT ); Tue, 25 Jan 2011 00:31:25 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=M/d4iBKBHQfAQiZJmgx5tnjb1lJhb4CQpe2KFOP5GC92xbchgPhB0rB5D9FwD5YFI5 JRc3XKB7+wBvgYj1G+FVS318Wd+zS5a0zKfftS1b2tsoJiOR5w7EIhze1nlnxdnPCK1e fo2TwItJCrrX/4zULOuMTzh3ZUELRyokJaheA= Date: Mon, 24 Jan 2011 21:31:17 -0800 From: Dmitry Torokhov To: Mark Lord Cc: Linux Kernel , linux-input@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ? Message-ID: <20110125053117.GD7850@core.coreip.homeip.net> References: <4D3C5F73.2050408@teksavvy.com> <20110124175456.GA17855@core.coreip.homeip.net> <4D3E1A08.5060303@teksavvy.com> <20110125005555.GA18338@core.coreip.homeip.net> <4D3E4DD1.60705@teksavvy.com> <20110125042016.GA7850@core.coreip.homeip.net> <4D3E5372.9010305@teksavvy.com> <20110125045559.GB7850@core.coreip.homeip.net> <4D3E59CA.6070107@teksavvy.com> <4D3E5A91.30207@teksavvy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D3E5A91.30207@teksavvy.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: > On 11-01-25 12:04 AM, Mark Lord wrote: > > On 11-01-24 11:55 PM, Dmitry Torokhov wrote: > >> On Mon, Jan 24, 2011 at 11:37:06PM -0500, Mark Lord wrote: > > .. > >>> This results in (map->size==10) for 2.6.36+ (wrong), > >>> and a much larger map->size for 2.6.35 and earlier. > >>> > >>> So perhaps EVIOCGKEYCODE has changed? > >>> > >> > >> So the utility expects that all devices have flat scancode space and > >> driver might have changed so it does not recognize scancode 10 as valid > >> scancode anymore. > >> > >> The options are: > >> > >> 1. Convert to EVIOCGKEYCODE2 > >> 2. Ignore errors from EVIOCGKEYCODE and go through all 65536 iterations. > > > > or 3. Revert/fix the in-kernel regression. > > > > The EVIOCGKEYCODE ioctl is supposed to return KEY_RESERVED for unmapped > > (but value) keycodes, and only return -EINVAL when the keycode itself > > is out of range. > > > > That's how it worked in all kernels prior to 2.6.36, > > and now it is broken. It now returns -EINVAL for any unmapped keycode, > > even though keycodes higher than that still have mappings. > > > > This is a bug, a regression, and breaks userspace. > > I haven't identified *where* in the kernel the breakage happened, > > though.. that code confuses me. :) > > Note that this device DOES have "flat scancode space", > and the kernel is now incorrectly signalling an error (-EINVAL) > in response to a perfectly valid query of a VALID (and mappable) > keycode on the remote control > > The code really is a valid button, it just doesn't have a default mapping > set by the kernel (I can set a mapping for that code from userspace and it works). > OK, in this case let's ping Mauro - I think he done the adjustments to IR keymap hanlding. Thanks. -- Dmitry