From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784Ab1AZISo (ORCPT ); Wed, 26 Jan 2011 03:18:44 -0500 Received: from gir.skynet.ie ([193.1.99.77]:46611 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697Ab1AZISn (ORCPT ); Wed, 26 Jan 2011 03:18:43 -0500 Date: Wed, 26 Jan 2011 08:18:19 +0000 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML Subject: Re: [PATCH 3/3] compaction: Check migrate_pages's return value instead of list_empty Message-ID: <20110126081819.GL18984@csn.ul.ie> References: <8d3d2470533ab99564cdcec88bfb7fcc96b383d3.1295539829.git.minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <8d3d2470533ab99564cdcec88bfb7fcc96b383d3.1295539829.git.minchan.kim@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 21, 2011 at 01:17:07AM +0900, Minchan Kim wrote: > Many migrate_page's caller check return value instead of list_empy by > cf608ac19c95804dc2. > This patch makes compaction's migrate_pages consistent with others. > This patch should not change old behavior. > > NOTE : This patch depends on [1/3]. > > Cc: Mel Gorman > Signed-off-by: Minchan Kim I haven't tested but I am not spotting a problem; Acked-by: Mel Gorman -- Mel Gorman Linux Technology Center IBM Dublin Software Lab