From: Frederic Weisbecker <fweisbec@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Miller <davem@davemloft.net>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: fix alloc_callchain_buffers()
Date: Wed, 26 Jan 2011 17:23:12 +0100 [thread overview]
Message-ID: <20110126162309.GB1757@nowhere> (raw)
In-Reply-To: <1295980851.3588.351.camel@edumazet-laptop>
On Tue, Jan 25, 2011 at 07:40:51PM +0100, Eric Dumazet wrote:
> Commit 927c7a9e92c4 ( perf: Fix race in callchains ) introduced a
> mismatch in the sizing of struct callchain_cpus_entries.
>
> nr_cpu_ids must be used instead of num_possible_cpus(), or we might get
> out of bound memory accesses on some machines.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> CC: Arnaldo Carvalho de Melo <acme@redhat.com>
> CC: David Miller <davem@davemloft.net>
> CC: Stephane Eranian <eranian@google.com>
> CC: stable@kernel.org
Good catch, thanks!
next prev parent reply other threads:[~2011-01-26 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 18:40 Eric Dumazet
2011-01-26 7:25 ` [tip:perf/urgent] perf: Fix alloc_callchain_buffers() tip-bot for Eric Dumazet
2011-01-26 16:23 ` Frederic Weisbecker [this message]
2011-01-27 18:28 ` tip-bot for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126162309.GB1757@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=eranian@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®