From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290Ab1A1QpY (ORCPT ); Fri, 28 Jan 2011 11:45:24 -0500 Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:50647 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754518Ab1A1QpW (ORCPT ); Fri, 28 Jan 2011 11:45:22 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=h2yeJ4ZP6yX90wWf+6ZCEpJ86USq7UIiH8XYS5CqVN58UxfIzXuDNoqKUBMKcRzUjYGJWkUgOAgpiUTFw0Jk3zLczEmiwD0kq7F83RBtfys8rbg/j/nGPjw4LYN5P9LK; Date: Fri, 28 Jan 2011 08:45:18 -0800 From: Jesse Barnes To: Cc: , , , , , , Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Message-ID: <20110128084518.7783091e@jbarnes-desktop> In-Reply-To: <20110128155337.GA27642@fedora14-r610.oslab.blr.amer.dell.com> References: <20110112203414.GA5657@fedora14-r610.oslab.blr.amer.dell.com> <20110112160229.7b8d82c1@jbarnes-desktop> <20110113075556.789ac3c3@jbarnes-vaio.home> <20110113162755.GA5872@fedora14-r610.oslab.blr.amer.dell.com> <20110114154458.GA18289@fedora14-r610.oslab.blr.amer.dell.com> <20110115080949.62176a3c.sfr@canb.auug.org.au> <20110117195215.GA2708@fedora14-r610.oslab.blr.amer.dell.com> <20110120190459.GA30978@fedora14-r610.oslab.blr.amer.dell.com> <20110128155337.GA27642@fedora14-r610.oslab.blr.amer.dell.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.174.193.198 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jan 2011 07:30:36 -0800 wrote: > On Fri, Jan 21, 2011 at 12:11:50AM +0530, K, Narendra wrote: > > On Tue, Jan 18, 2011 at 12:58:48AM +0530, K, Narendra wrote: > > > On Sat, Jan 15, 2011 at 02:39:49AM +0530, Stephen Rothwell wrote: > > > > Hi Narendra, > > > > > > > > On Fri, 14 Jan 2011 20:52:42 +0530 wrote: > > > > > > > > > > This patch addresses the build failure described in this thread by > > > > > compiling fs/nls/nls_base.c always into vmlinux, thus making the base > > > > > nls functions available always. > > > > > > > > Even on platforms that don't support ACPI or DMI ... > > > > > > > > You should really restrict this to CONFIG_ACPI || CONFIG_DMI || > > > > CONFIG_NLS ... maybe create a CONFIG_NLS_BASE that is selected by ACPI, > > > > DMI and NLS? > > > > > > Hi Stephen, > > > > > > Thank you for the suggestions. > > > > > > I agree with your suggestion that we should compile nls_base.o > > > conditionally, only when ACPI || DMI || NLS. I have introduced a bew > > > config option CONFIG_NLS_BASE and made ACPI, DMI and NLS select it. > > > > > > V1 -> V2: > > > > > > 1. Conditionally compile fs/nls/nls_base.c by introducing a new config > > > option CONFIG_NLS_BASE, which is selected by (ACPI || DMI || NLS). > > > Behavior of the rest of the files under fs/nls is not changed. > > > > > > From: Narendra K > > > Subject: [PATCH V2] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig > > > > Hi, > > > > Please let me know if there are any concerns with Version 2 of the patch. > > If it looks good please consider it for inclusion. > > Hi Jesse, > > Please let me know if there are any concerns with this patch. If it is > acceptable, please consider this for inclusion. I think the fs stuff will have to get an ack from Al. If he doesn't like it, see my earlier mail for another suggestion. -- Jesse Barnes, Intel Open Source Technology Center