mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
	dri-devel@lists.freedesktop.org, Len Brown <len.brown@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: has the i915 "black screen" boot issue returned? [BISECTED]
Date: Fri, 28 Jan 2011 21:12:52 +0100	[thread overview]
Message-ID: <201101282112.52798.rjw@sisk.pl> (raw)
In-Reply-To: <alpine.DEB.2.00.1101281006550.3007@localhost6.localdomain6>

On Friday, January 28, 2011, Robert P. J. Day wrote:
> On Fri, 28 Jan 2011, Chris Wilson wrote:
> 
> > On Fri, 28 Jan 2011 09:51:01 -0500 (EST), "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
> > >   sadly, no change -- still black screen.  again, rebooted
> > > successfully under commit 8a327f23.  just to be clear, here's "git
> > > diff":
> > >
> > > $ git diff
> > > diff --git a/include/linux/acpi_io.h b/include/linux/acpi_io.h
> > > index 7180013..e035f3c 100644
> > > --- a/include/linux/acpi_io.h
> > > +++ b/include/linux/acpi_io.h
> > > @@ -7,7 +7,7 @@
> > >  static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys,
> > >                                             acpi_size size)
> > >  {
> > > -       return ioremap_cache(phys, size);
> > > +       return ioremap(phys, size);
> > >  }
> >
> > Ok, that implies the new mapping is fine and not the cause of the issue.
> >
> > Instead you have some OpRegion related regression hidden until till now
> > because the conflicting mapping disabled it for i915.
> >
> > That would be easy to test by returning early in intel_opregion_setup():
> >
> > diff --git a/drivers/gpu/drm/i915/intel_opregion.c
> > b/drivers/gpu/drm/i915/intel_
> > index 9efccb9..8c93201 100644
> > --- a/drivers/gpu/drm/i915/intel_opregion.c
> > +++ b/drivers/gpu/drm/i915/intel_opregion.c
> > @@ -470,6 +470,8 @@ int intel_opregion_setup(struct drm_device *dev)
> >         u32 asls, mboxes;
> >         int err = 0;
> >
> > +       return -ENOTSUPP;
> > +
> >
> >         pci_read_config_dword(dev->pdev, PCI_ASLS, &asls);
> >         DRM_DEBUG_DRIVER("graphic opregion physical addr: 0x%x\n", asls);
> >         if (asls == 0) {
> >
> 
> so you want me to revert to a stock b705120e before doing the above?

Alternatively, you could take the vanilla Linus' tree and replace
ioremap_cache() with ioremap() in include/linux/acpi_io.h .  Please try that
and see if it makes a difference.

Thanks,
Rafael

  reply	other threads:[~2011-01-28 20:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.DEB.2.00.1101260634300.10774@localhost6.localdomain6>
     [not found] ` <b9dded$hp9kfu@orsmga002.jf.intel.com>
     [not found]   ` <alpine.DEB.2.00.1101270641490.2923@localhost6.localdomain6>
     [not found]     ` <b9dded$hpa5rf@orsmga002.jf.intel.com>
     [not found]       ` <alpine.DEB.2.00.1101270710510.17636@localhost6.localdomain6>
     [not found]         ` <1bdc18$jdgfni@fmsmga002.fm.intel.com>
     [not found]           ` <alpine.DEB.2.00.1101270840380.2736@localhost6.localdomain6>
     [not found]             ` <0d30dc$ksovh8@orsmga001.jf.intel.com>
     [not found]               ` <alpine.DEB.2.00.1101270854420.4898@localhost6.localdomain6>
     [not found]                 ` <b7da2f$q8lpcn@fmsmga001.fm.intel.com>
     [not found]                   ` <alpine.DEB.2.00.1101271634260.2761@localhost6.localdomain6>
     [not found]                     ` <alpine.DEB.2.00.1101271730400.2583@localhost6.localdomain6>
     [not found]                       ` <849307$bbem1h@azsmga001.ch.intel.com>
     [not found]                         ` <alpine.DEB.2.00.1101280421430.2739@localhost6.localdomain6>
     [not found]                           ` <0d30dc$kt3gd6@orsmga001.jf.intel.com>
     [not found]                             ` <alpine.DEB.2.00.1101280850550.2796@localhost6.localdomain6>
     [not found]                               ` <849307$bbh907@azsmga001.ch.intel.com>
2011-01-28 14:10                                 ` Robert P. J. Day
2011-01-28 14:32                                 ` Robert P. J. Day
2011-01-28 14:36                                   ` Chris Wilson
2011-01-28 14:51                                     ` Robert P. J. Day
2011-01-28 15:04                                       ` Chris Wilson
2011-01-28 15:08                                         ` Robert P. J. Day
2011-01-28 20:12                                           ` Rafael J. Wysocki [this message]
2011-01-28 20:21                                             ` Robert P. J. Day
2011-01-28 20:46                                             ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101282112.52798.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®