From: David Miller <davem@davemloft.net>
To: alek.du@intel.com
Cc: buytenh@secretlab.ca, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] langwell_gpio: Fix deprecated refs to irq_desc->chip and chip->eoi
Date: Sat, 29 Jan 2011 22:05:38 -0800 (PST) [thread overview]
Message-ID: <20110129.220538.104056157.davem@davemloft.net> (raw)
In-Reply-To: <20110125.225034.39182208.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 25 Jan 2011 22:50:34 -0800 (PST)
> From: "Du, Alek" <alek.du@intel.com>
> Date: Wed, 26 Jan 2011 14:48:02 +0800
>
>> Another patch from Feng Tang already covers this and picked up by Andrew Morton.
>>
>> [patch 04/23] langwell_gpio: modify EOI handling following change of kernel irq subsystem
>
> Ok, thanks.
It doesn't cover "this". Somthing like my patch is still necessary to
get this driver to build:
drivers/gpio/langwell_gpio.c: In function 'lnw_irq_handler':
drivers/gpio/langwell_gpio.c:210:10: error: 'struct irq_desc' has no member named 'chip'
drivers/gpio/langwell_gpio.c:211:7: error: 'struct irq_desc' has no member named 'chip'
--------------------
Subject: [PATCH] langwell_gpio: Fix deprecated refs to irq_desc->chip
From: David Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
index 54d70a4..fb3e439 100644
--- a/drivers/gpio/langwell_gpio.c
+++ b/drivers/gpio/langwell_gpio.c
@@ -207,8 +207,8 @@ static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
writel(gedr_v, gedr);
}
- if (desc->chip->irq_eoi)
- desc->chip->irq_eoi(irq_get_irq_data(irq));
+ if (desc->irq_data.chip->irq_eoi)
+ desc->irq_data.chip->irq_eoi(irq_get_irq_data(irq));
else
dev_warn(lnw->chip.dev, "missing EOI handler for irq %d\n", irq);
prev parent reply other threads:[~2011-01-30 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 6:29 David Miller
2011-01-26 6:48 ` Du, Alek
2011-01-26 6:50 ` David Miller
2011-01-30 6:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110129.220538.104056157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alek.du@intel.com \
--cc=buytenh@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®