From: Roman Fietze <roman.fietze@telemotive.de>
To: Joe Perches <realty@perches.com>
Cc: Jason Baron <jbaron@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fixed proposal to add dynamic debug feature for print_hex_dump
Date: Tue, 1 Feb 2011 13:45:30 +0100 [thread overview]
Message-ID: <201102011345.30618.roman.fietze@telemotive.de> (raw)
In-Reply-To: <1295029146.4099.71.camel@Joe-Laptop>
Hello Joe,
On Friday, 14.January.2011 19:19:06 Joe Perches wrote:
> A high percentage of these print_hex_dump() uses are
> (,,, 16, 1, buf, len, true) so there's some value
> in doing this.
I found some calls using 16 and 32 bit words to dump their data, e.g.
in UBIFS, NFC, USB IP, MTD Tests and libata, so I think we should
rather ask the callers to add the "16, 1," for byte dumps instead of
rendering hex_dump_xx unusable in quite some cases by defaulting to
byte dumps.
> I suggest simplifying naming to just hex_dump_<level>.
Done.
> Adding a hex_dump_printk function to hexdump.c
If the first of the following two patches will be accepted I can work
on that issue.
Roman
--
Roman Fietze Telemotive AG Buero Muehlhausen
Breitwiesen 73347 Muehlhausen
Tel.: +49(0)7335/18493-45 http://www.telemotive.de
next prev parent reply other threads:[~2011-02-01 12:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 14:17 [PATCH] Proposal to add dynamic debug feature for print_hex_dump [0/3] Roman Fietze
2010-12-03 14:19 ` [PATCH] Proposal to add dynamic debug feature for print_hex_dump [1/2] Roman Fietze
2010-12-03 20:35 ` Joe Perches
2010-12-03 14:21 ` [PATCH] Proposal to add dynamic debug feature for print_hex_dump [2/2] Roman Fietze
2010-12-03 20:37 ` Joe Perches
2010-12-06 5:58 ` Roman Fietze
2010-12-06 6:04 ` Joe Perches
[not found] ` <201012061113.01576.roman.fietze@telemotive.de>
[not found] ` <1291822758.1240.8.camel@Joe-Laptop>
2011-01-14 8:43 ` [PATCH] Proposal to add dynamic debug feature for print_hex_dump Roman Fietze
2011-01-14 18:19 ` Joe Perches
2011-02-01 12:45 ` Roman Fietze [this message]
2011-02-01 12:46 ` [PATCH 1/2] printk.h dynamic_debug.h: add hex_dump_<level> macros Roman Fietze
2011-02-01 12:48 ` [PATCH 2/2] hex_dump_dbg: replace all calls to print_hex_dump with level KERN_DEBUG Roman Fietze
2011-02-02 1:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102011345.30618.roman.fietze@telemotive.de \
--to=roman.fietze@telemotive.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=realty@perches.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®