mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH] tmio_mmc: Improve readability of the output of pr_debug_status()
Date: Sat, 5 Feb 2011 06:41:24 +0900	[thread overview]
Message-ID: <20110204214124.GH21870@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1102042028120.14717@axis700.grange>

On Fri, Feb 04, 2011 at 08:34:54PM +0100, Guennadi Liakhovetski wrote:
> On Fri, 4 Feb 2011, Simon Horman wrote:
> 
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> > ---
> >  drivers/mmc/host/tmio_mmc.h |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> > index 6f724de..811427d 100644
> > --- a/drivers/mmc/host/tmio_mmc.h
> > +++ b/drivers/mmc/host/tmio_mmc.h
> > @@ -237,12 +237,16 @@ static inline void tmio_mmc_kunmap_atomic(void *virt,
> >  
> >  #define STATUS_TO_TEXT(a) \
> >  	do { \
> > -		if (status & TMIO_STAT_##a) \
> > +		if (status & TMIO_STAT_##a) { \
> > +			if (i++) \
> > +				printk("|"); \
> >  			printk(#a); \
> > +		} \
> 
> Personally, I find it a bad idea to use variables in macros without 
> explicitly passing them in the parameter list. Yes, this macro is already 
> using "status" in that way, still, I don't think, that adding more such 
> variables is good. Why not make it STATUS_TO_TEXT(a, status, i) and also 
> add spaces for better yet readability like printk(" | ")?

Point taken, I will send v2 shortly.
Though the STATUS_TO_TEXT(a, status, i) change
does seem to make pr_debug_status() rather a lot noisier.


      reply	other threads:[~2011-02-04 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04  8:33 Simon Horman
2011-02-04 19:34 ` Guennadi Liakhovetski
2011-02-04 21:41   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110204214124.GH21870@verge.net.au \
    --to=horms@verge.net.au \
    --cc=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=ian@mnementh.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®