From: Kees Cook <kees.cook@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>,
Marcus Meissner <meissner@suse.de>,
Jason Wessel <jason.wessel@windriver.com>,
Eugene Teo <eugeneteo@kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Len Brown <len.brown@intel.com>, Changli Gao <xiaosuo@gmail.com>,
Dan Rosenberg <drosenberg@vsecurity.com>
Subject: Re: [PATCH v2] use %pK for /proc/kallsyms and /proc/modules
Date: Fri, 4 Feb 2011 14:09:44 -0800 [thread overview]
Message-ID: <20110204220944.GN5503@outflux.net> (raw)
In-Reply-To: <20110204140351.f9066af0.akpm@linux-foundation.org>
Hi Andrew,
On Fri, Feb 04, 2011 at 02:03:51PM -0800, Andrew Morton wrote:
> kernel/kallsyms.c: In function 's_show':
> kernel/kallsyms.c:481: warning: format '%p' expects type 'void *', but argument 3 has type 'long unsigned int'
> kernel/kallsyms.c:484: warning: format '%p' expects type 'void *', but argument 3 has type 'long unsigned int'
> kernel/module.c: In function 'module_sect_show':
> kernel/module.c:1171: warning: format '%p' expects type 'void *', but argument 3 has type 'long unsigned int'
> kernel/module.c:1171: warning: format '%p' expects type 'void *', but argument 3 has type 'long unsigned int'
>
> I'm struggling to see how this could have been compile-time or runtime
> tested?
I run-time tested it plenty. The thread contains the various discussions
about compile-time warnings, so I suspect in the last version, I didn't go
examine the warnings (since the origin of the other warnings went away).
I can send a patch to fix it up to cast everything to (void*) if you want?
-Kees
--
Kees Cook
Ubuntu Security Team
next prev parent reply other threads:[~2011-02-04 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 0:41 Kees Cook
2011-02-04 22:03 ` Andrew Morton
2011-02-04 22:09 ` Kees Cook [this message]
2011-02-04 22:21 ` Andrew Morton
2011-02-04 22:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204220944.GN5503@outflux.net \
--to=kees.cook@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=drosenberg@vsecurity.com \
--cc=eugeneteo@kernel.org \
--cc=jason.wessel@windriver.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®