Re: [PATCH] PCI: Avoid potential NULL pointer dereference in pci_scan_bridge

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Mon, 24 Jan 2011 21:14:33 +0100 (CET)
Jesper Juhl <jj@chaosbits.net> wrote:

> pci_add_new_bus() calls pci_alloc_child_bus() which calls pci_alloc_bus() 
> that allocates memory dynamically with kzalloc(). The return value of 
> kzalloc() is the pointer that's eventually returned from 
> pci_add_new_bus(), so since kzalloc() can fail and return NULL so can 
> pci_add_new_bus(). Thus we may end up dereferencing a NULL pointer in 
> drivers/pci/probe.c::pci_scan_bridge(). Seems to me we should test for 
> this and bail out if it happens rather than crashing.
> Also removed some trailing whitespace that bugged me while looking at 
> this.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---

Applied to linux-next (in the absence of actual reports I'll be
conservative), thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center