From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: reduce ata_pci_[sff,bmdma]_init_one() size
Date: Wed, 9 Feb 2011 21:17:38 +0000 [thread overview]
Message-ID: <20110209211738.2b363dca@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4D52F43F.5040507@ru.mvista.com>
> Perhaps this will save even more:
>
> if (bmdma)
> pci_set_master(pdev);
> rc = ata_pci_sff_activate_host(host, bmdma ? ata_bmdma_interrupt :
> ata_sff_interrupt, sht);
gcc is usually smart enough to work that out - and it's definitely easier
to read as Bartlomiej has it.
I agree with the comment that libata-sata rather than ifdefs would be
good for the SATA bit as well btw.
And yes ADMA was designed for PATA
next prev parent reply other threads:[~2011-02-09 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 14:15 Bartlomiej Zolnierkiewicz
2011-02-09 20:08 ` Sergei Shtylyov
2011-02-09 21:17 ` Alan Cox [this message]
2011-10-11 17:22 Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209211738.2b363dca@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®