From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: gregkh@suse.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, david@woodhou.se,
david.woodhouse@intel.com
Subject: Re: [RFC PATCH 06/13] Intel(R) MEI Driver
Date: Thu, 10 Feb 2011 13:52:32 +0000 [thread overview]
Message-ID: <20110210135232.4f87df85@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <b7da2f$qd3nfe@fmsmga001.fm.intel.com>
> +/**
> + * flow_ctrl_creds - checks flow_control credentials.
There seem to be an enormous number of global variables and not all of
them have mei_xxx prefixes on either.
I can't tell if this is because the driver wants restructuring as there
simply isn't an overall visible architecture or design to the code I can
see, nor any documentation on what it is doing at the higher levels or
the API.
prev parent reply other threads:[~2011-02-10 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 9:55 Oren Weil
2011-02-10 13:52 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210135232.4f87df85@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=david.woodhouse@intel.com \
--cc=david@woodhou.se \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®