From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: tlambert@chromium.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: fixed EVIOCGRAB iterative grab/release.
Date: Thu, 10 Feb 2011 15:54:47 -0800 [thread overview]
Message-ID: <20110210235447.GA12313@core.coreip.homeip.net> (raw)
In-Reply-To: <1297381370-16388-1-git-send-email-tlambert@chromium.org>
On Thu, Feb 10, 2011 at 03:42:50PM -0800, tlambert@chromium.org wrote:
> From: Terry Lambert <tlambert@chromium.org>
>
> Fixed order of calls in evdev_ungrab to allow iterative use of
> code which grabs and releases input event devices.
>
Sorry, could you please be more verbose?
> Signed-off-by: Terry Lambert <tlambert@chromium.org>
> ---
> drivers/input/evdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index c8471a2..0bac8da 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -160,9 +160,9 @@ static int evdev_ungrab(struct evdev *evdev, struct evdev_client *client)
> if (evdev->grab != client)
> return -EINVAL;
>
> + input_release_device(&evdev->handle);
> rcu_assign_pointer(evdev->grab, NULL);
> synchronize_rcu();
> - input_release_device(&evdev->handle);
>
> return 0;
> }
> --
> 1.7.3.1
>
--
Dmitry
next prev parent reply other threads:[~2011-02-10 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 23:42 tlambert
2011-02-10 23:54 ` Dmitry Torokhov [this message]
2011-02-11 0:41 ` Terry Lambert
2011-02-11 1:21 ` Dmitry Torokhov
2011-02-11 10:04 ` Henrik Rydberg
2011-02-11 17:55 ` Terry Lambert
2011-02-11 18:32 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210235447.GA12313@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tlambert@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®