From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org, netdev <netdev@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
Kurt Van Dijck <kurt.van.dijck@eia.be>
Subject: [PATCH -next/mmotm] net/can: fix softing build errors
Date: Fri, 11 Feb 2011 22:33:12 -0800 [thread overview]
Message-ID: <20110211223312.be571303.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201102110100.p1B10sDx029244@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix can/softing build errors due to kconfig error.
kconfig tells us about a problem...
warning: (CAN_SOFTING_CS) selects CAN_SOFTING which has unmet direct dependencies (NET && CAN && CAN_DEV && HAS_IOMEM)
and then this is what happens due to that kconfig problem:
ERROR: "register_candev" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "alloc_candev" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "can_bus_off" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "close_candev" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "free_candev" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "unregister_candev" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "alloc_can_skb" [drivers/net/can/softing/softing.ko] undefined!
ERROR: "open_candev" [drivers/net/can/softing/softing.ko] undefined!
with this partial config:
CONFIG_CAN=m
# CONFIG_CAN_RAW is not set
# CONFIG_CAN_BCM is not set
# CAN Device Drivers
# CONFIG_CAN_VCAN is not set
CONFIG_CAN_SLCAN=m
# CONFIG_CAN_DEV is not set
CONFIG_CAN_SOFTING=m
CONFIG_CAN_SOFTING_CS=m
# CONFIG_CAN_DEBUG_DEVICES is not set
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Kurt Van Dijck <kurt.van.dijck@eia.be>
---
drivers/net/can/softing/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2011-0210-1626.orig/drivers/net/can/softing/Kconfig
+++ mmotm-2011-0210-1626/drivers/net/can/softing/Kconfig
@@ -18,6 +18,7 @@ config CAN_SOFTING
config CAN_SOFTING_CS
tristate "Softing Gmbh CAN pcmcia cards"
depends on PCMCIA
+ depends on CAN_DEV && HAS_IOMEM
select CAN_SOFTING
---help---
Support for PCMCIA cards from Softing Gmbh & some cards
next prev parent reply other threads:[~2011-02-12 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 0:26 mmotm 2011-02-10-16-26 uploaded akpm
2011-02-11 21:52 ` Valdis.Kletnieks
2011-02-11 22:09 ` Dan Magenheimer
2011-02-12 2:47 ` mmotm 2011-02-10-16-26 uploaded (zcache') Randy Dunlap
2011-02-12 6:33 ` Randy Dunlap [this message]
2011-02-12 11:15 ` [PATCH -next/mmotm] net/can: fix softing build errors Kurt Van Dijck
2011-02-12 16:02 ` Randy Dunlap
2011-02-13 13:37 ` Kurt Van Dijck
2011-02-13 16:01 ` Randy Dunlap
2011-02-13 18:38 ` David Miller
2011-02-14 7:55 ` [PATCH] net/can/softing: make CAN_SOFTING_CS depend on CAN_SOFTING Kurt Van Dijck
2011-02-14 19:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110211223312.be571303.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kurt.van.dijck@eia.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®