mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees.cook@canonical.com>
To: Corbin Simpson <mostawesomedude@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	Eugene Teo <eugeneteo@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: do not leak kernel addresses via /proc/dri/*/vma
Date: Sat, 12 Feb 2011 14:08:26 -0800	[thread overview]
Message-ID: <20110212220826.GA4135@outflux.net> (raw)
In-Reply-To: <AANLkTiniMPKD6EGpQ=TAbeS4tFVtZybcf-8kFuNbU7t_@mail.gmail.com>

Hi Corbin,

On Sat, Feb 12, 2011 at 10:13:04AM -0800, Corbin Simpson wrote:
> On Fri, Feb 11, 2011 at 7:29 PM, Kees Cook <kees.cook@canonical.com> wrote:
> > In the continuing effort to avoid kernel addresses leaking to unprivileged
> > users, this patch switches to %pK for /proc/dri/*/vma.
> 
> This is a highly reasonable patch. Does 0x%pK show up as 0x0x0 in the
> log, or just 0x0? Other than that...
> Reviewed-by: Corbin Simpson <MostAwesomeDude@gmail.com>

Thanks! The default for %p (and %pK) is without the 0x prefix, and 0-padded to sizeof(void*)
character. So 0x%pK will show as 0x00000000 on 32bit to a regular user, etc.

-Kees

-- 
Kees Cook
Ubuntu Security Team

      reply	other threads:[~2011-02-12 22:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-12  3:29 Kees Cook
2011-02-12 18:13 ` Corbin Simpson
2011-02-12 22:08   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110212220826.GA4135@outflux.net \
    --to=kees.cook@canonical.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drosenberg@vsecurity.com \
    --cc=eugeneteo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mostawesomedude@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®