From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: eranian@google.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com,
perfmon2-devel@lists.sf.net, eranian@gmail.com,
robert.richter@amd.com, acme@redhat.com, lizf@cn.fujitsu.com,
Paul Menage <menage@google.com>
Subject: Re: [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback
Date: Sun, 13 Feb 2011 18:22:15 +0530 [thread overview]
Message-ID: <20110213125215.GB23919@balbir.in.ibm.com> (raw)
In-Reply-To: <1297095033.13327.46.camel@laptop>
* Peter Zijlstra <peterz@infradead.org> [2011-02-07 17:10:33]:
> On Thu, 2011-02-03 at 00:32 +0530, Balbir Singh wrote:
> > > No, just fixed. The callback as it exists isn't useful and leads to
> > > hacks like the above.
>
> ---
> Subject: cgroup: Fix cgroup_subsys::exit callback
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Mon Feb 07 17:02:20 CET 2011
>
> Make the ::exit method act like ::attach, it is after all very nearly
> the same thing.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> LKML-Reference: <new-submission>
> ---
> Index: linux-2.6/include/linux/cgroup.h
> ===================================================================
> --- linux-2.6.orig/include/linux/cgroup.h
> +++ linux-2.6/include/linux/cgroup.h
> @@ -474,7 +474,8 @@ struct cgroup_subsys {
> struct cgroup *old_cgrp, struct task_struct *tsk,
> bool threadgroup);
> void (*fork)(struct cgroup_subsys *ss, struct task_struct *task);
> - void (*exit)(struct cgroup_subsys *ss, struct task_struct *task);
> + void (*exit)(struct cgroup_subsys *ss, struct cgroup *cgrp,
> + struct cgroup *old_cgrp, struct task_struct *task);
The effective change I see
1. mutex_lock() being held
2. Old cgroup being passed as a part of the notification
Is 1 required? I don't see anything in the changelog. For (2), I don't
see it being used, is the use in the scheduler cgroup path/patch?
--
Three Cheers,
Balbir
next prev parent reply other threads:[~2011-02-13 12:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 13:30 [PATCH 1/2] perf_events: add cgroup support (v8) Stephane Eranian
2011-01-20 14:39 ` Peter Zijlstra
2011-01-20 14:46 ` Stephane Eranian
2011-02-02 11:29 ` Peter Zijlstra
2011-02-02 11:50 ` Balbir Singh
2011-02-02 12:46 ` Peter Zijlstra
2011-02-02 19:02 ` Balbir Singh
2011-02-07 16:10 ` [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback Peter Zijlstra
2011-02-07 19:28 ` Paul Menage
2011-02-07 20:02 ` Peter Zijlstra
2011-02-07 21:21 ` Paul Menage
2011-02-08 10:24 ` Peter Zijlstra
2011-02-10 2:04 ` Li Zefan
2011-02-11 12:13 ` Peter Zijlstra
2011-02-14 4:32 ` Paul Menage
2011-02-16 13:46 ` [tip:perf/core] " tip-bot for Peter Zijlstra
2011-02-13 12:52 ` Balbir Singh [this message]
2011-02-07 19:29 ` [PATCH 1/2] perf_events: add cgroup support (v8) Paul Menage
2011-02-07 20:09 ` Peter Zijlstra
2011-02-07 21:33 ` Paul Menage
2011-02-07 16:10 ` Peter Zijlstra
2011-02-07 20:30 ` Stephane Eranian
2011-02-08 22:31 ` Stephane Eranian
2011-02-09 9:47 ` Peter Zijlstra
2011-02-10 11:47 ` Stephane Eranian
2011-02-11 0:55 ` Li Zefan
2011-02-11 9:56 ` Stephane Eranian
2011-02-11 13:36 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110213125215.GB23919@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®