From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789Ab1BNT6G (ORCPT ); Mon, 14 Feb 2011 14:58:06 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:45339 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088Ab1BNT6E (ORCPT ); Mon, 14 Feb 2011 14:58:04 -0500 Date: Mon, 14 Feb 2011 20:58:02 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Richard Purdie Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: make *struct gpio_led_platform_data.leds const Message-ID: <20110214195802.GI13279@pengutronix.de> References: <1295430466-3250-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1295430466-3250-1-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Richard, On Wed, Jan 19, 2011 at 10:47:46AM +0100, Uwe Kleine-König wrote: > ... and fix a typo. > > Signed-off-by: Uwe Kleine-König ping > --- > drivers/leds/leds-net5501.c | 2 +- > include/linux/leds.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-net5501.c b/drivers/leds/leds-net5501.c > index 1739557..7e764b8 100644 > --- a/drivers/leds/leds-net5501.c > +++ b/drivers/leds/leds-net5501.c > @@ -19,7 +19,7 @@ > > #include > > -static struct gpio_led net5501_leds[] = { > +static const struct gpio_led net5501_leds[] = { > { > .name = "error", > .gpio = 6, > diff --git a/include/linux/leds.h b/include/linux/leds.h > index 0f19df9..383811d 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -194,11 +194,11 @@ struct gpio_led { > > struct gpio_led_platform_data { > int num_leds; > - struct gpio_led *leds; > + const struct gpio_led *leds; > > #define GPIO_LED_NO_BLINK_LOW 0 /* No blink GPIO state low */ > #define GPIO_LED_NO_BLINK_HIGH 1 /* No blink GPIO state high */ > -#define GPIO_LED_BLINK 2 /* Plase, blink */ > +#define GPIO_LED_BLINK 2 /* Please, blink */ > int (*gpio_blink_set)(unsigned gpio, int state, > unsigned long *delay_on, > unsigned long *delay_off); > -- > 1.7.2.3 > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |