From: Grant Likely <grant.likely@secretlab.ca>
To: Thomas Chou <thomas@wytron.com.tw>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-kernel@vger.kernel.org, nios2-dev@sopc.et.ntust.edu.tw,
devicetree-discuss@lists.ozlabs.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-ocores: register devices on child nodes
Date: Tue, 15 Feb 2011 21:35:40 -0700 [thread overview]
Message-ID: <20110216043540.GB11684@angua.secretlab.ca> (raw)
In-Reply-To: <1297306314-11483-1-git-send-email-thomas@wytron.com.tw>
On Thu, Feb 10, 2011 at 10:51:54AM +0800, Thomas Chou wrote:
> This patch registers devices on the devicetree child nodes to the bus.
> Also removes one trailing whitespace.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Ben, do you want to pick this one up? Or should I merge it via my
devicetree branch?
g.
> ---
> drivers/i2c/busses/i2c-ocores.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index ef3bcb1..c63838f 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -18,7 +18,7 @@
> * - interrupts : interrupt number
> * - regstep : size of device registers in bytes
> * - clock-frequency : frequency of bus clock in Hz
> - *
> + *
> * Example:
> *
> * i2c0: ocores@a0000000 {
> @@ -55,6 +55,7 @@
> #include <linux/i2c-ocores.h>
> #include <linux/slab.h>
> #include <linux/io.h>
> +#include <linux/of_i2c.h>
>
> struct ocores_i2c {
> void __iomem *base;
> @@ -347,6 +348,9 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev)
> i2c_new_device(&i2c->adap, pdata->devices + i);
> }
>
> + /* Now register all the child nodes */
> + of_i2c_register_devices(&i2c->adap);
> +
> return 0;
> }
>
> --
> 1.7.4
>
next prev parent reply other threads:[~2011-02-16 4:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 2:51 Thomas Chou
2011-02-16 4:35 ` Grant Likely [this message]
2011-02-20 23:28 ` Ben Dooks
2011-02-21 3:40 ` Grant Likely
2011-02-23 0:12 ` Ben Dooks
2011-02-23 0:31 ` Thomas Chou
2011-02-23 1:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216043540.GB11684@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nios2-dev@sopc.et.ntust.edu.tw \
--cc=thomas@wytron.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®