From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305Ab1BPPif (ORCPT ); Wed, 16 Feb 2011 10:38:35 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:55012 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418Ab1BPPie (ORCPT ); Wed, 16 Feb 2011 10:38:34 -0500 Date: Wed, 16 Feb 2011 16:38:25 +0100 From: Ingo Molnar To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH] x86: use bitmap library functions Message-ID: <20110216153825.GA18805@elte.hu> References: <1297867715-20394-1-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1297867715-20394-1-git-send-email-akinobu.mita@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Akinobu Mita wrote: > Use bitmap_set()/bitmap_clear() to fill/zero a region of a bitmap > instead of doing set_bit()/clear_bit() each bit. > > Signed-off-by: Akinobu Mita > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > --- > arch/x86/kernel/ioport.c | 20 +++++--------------- > 1 files changed, 5 insertions(+), 15 deletions(-) Before we can merge this it would be nice to tested this using sys_ioperm(), to make sure port IO still gets denied/allowed as expected. You can check /proc/ioperm to see which ports are (probably) safe to read: 0x80/0xed is usually safe to read/write. Ingo