From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Drake <dsd@laptop.org>
Cc: cbou@mail.ru, dwmw2@infradead.org, linux-kernel@vger.kernel.org,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, dilinger@queued.net
Subject: Re: [PATCH v2] olpc_battery: convert to platform device
Date: Wed, 16 Feb 2011 08:52:48 -0800 [thread overview]
Message-ID: <20110216165247.GC29796@core.coreip.homeip.net> (raw)
In-Reply-To: <20110216142931.694DE9D401C@zog.reactivated.net>
On Wed, Feb 16, 2011 at 02:29:31PM +0000, Daniel Drake wrote:
>
> -static void __exit olpc_bat_exit(void)
> +static int __exit olpc_battery_remove(struct platform_device *pdev)
...
> + .remove = __devexit_p(olpc_battery_remove),
olpc_battery_remove should be annotated as __devexit. Sorry for not
noticing this before. Otherwise:
Reviewed-by: Dmitry Torokhov <dtor@mail.ru>
Thanks.
--
Dmitry
prev parent reply other threads:[~2011-02-16 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 14:29 Daniel Drake
2011-02-16 16:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216165247.GC29796@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=cbou@mail.ru \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®