From: NeilBrown <neilb@suse.de>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <jaxboe@fusionio.com>, linux-kernel@vger.kernel.org
Subject: Re: blk_throtl_exit taking q->queue_lock is problematic
Date: Thu, 17 Feb 2011 16:55:01 +1100 [thread overview]
Message-ID: <20110217165501.47f3c26f@notabene.brown> (raw)
In-Reply-To: <20110217011029.GA6793@redhat.com>
On Wed, 16 Feb 2011 20:10:29 -0500 Vivek Goyal <vgoyal@redhat.com> wrote:
> So is it possible to keep the spinlock intact when md is calling up
> blk_cleanup_queue()?
>
It would be possible, yes - but messy. I would probably end up just making
->queue_lock always point to __queue_lock, and then only take it at the
places where I call 'block' code which wants to test to see if it is
currently held (like the plugging routines).
The queue lock (and most of the request queue) is simply irrelevant for md.
I would prefer to get away from having to touch it at all...
I'll see how messy it would be to stop using it completely and it can just be
__queue_lock.
Though for me - it would be much easier if you just used __queue_lock .....
NeilBrown
next prev parent reply other threads:[~2011-02-17 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 7:31 NeilBrown
2011-02-16 15:53 ` Vivek Goyal
2011-02-17 0:35 ` NeilBrown
2011-02-17 1:10 ` Vivek Goyal
2011-02-17 5:55 ` NeilBrown [this message]
2011-02-17 15:01 ` Vivek Goyal
2011-02-17 16:59 ` Vivek Goyal
2011-02-18 2:40 ` NeilBrown
2011-02-18 3:19 ` Mike Snitzer
2011-02-18 3:33 ` NeilBrown
2011-02-18 14:04 ` Mike Snitzer
2011-02-18 15:04 ` Vivek Goyal
2011-02-21 7:24 ` NeilBrown
2011-02-21 14:42 ` Vivek Goyal
2011-02-18 15:05 ` Vivek Goyal
2011-02-17 20:00 ` Vivek Goyal
2011-02-18 1:57 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217165501.47f3c26f@notabene.brown \
--to=neilb@suse.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome