From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: james_p_freyensee@linux.intel.com
Cc: Greg KH <greg@kroah.com>, Alan Cox <alan@linux.intel.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
suhail.ahmed@intel.com
Subject: Re: [PATCH 07/12] n_tracerouter and n_tracesink additions.
Date: Thu, 24 Feb 2011 11:52:29 +0000 [thread overview]
Message-ID: <20110224115229.3e482bf2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1297971806.3038.30.camel@localhost>
> > > +#define N_TRACESINK 23 /* Trace data routing for MIPI P1149.7 */
> > > +#define N_TRACEROUTER 24 /* Trace data routing for MIPI P1149.7 */
> >
> > Two new ones? Really? Alan, no objection from you on this?
>
> I'll let Alan chime in, but I did have Alan review this code before I
> submitted here.
There isn't really an elegant way of avoiding that. What probably does
want doing for a final merge is to make them more generic. So that
anything can be a source or a sink that meets a basic interface.
Then you'd be able to do
set ldisc to tracesink
ioctl (something or other) "attach to sink of
name 'modem/mipi/p1149.7'
or similar.
That would need a struct of some sort and a register_sink/unregister_sink
method. Ditto for tracerouter. Obviously for now only the current drivers
would support it but the interface is then there for anything else
Alan
next prev parent reply other threads:[~2011-02-24 11:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 19:34 Resend: Request for review and addition of PTI implementation into kernel james_p_freyensee
2011-02-08 19:34 ` [PATCH 01/12] export kernel call get_task_comm() james_p_freyensee
2011-02-08 19:34 ` [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-08 19:34 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-08 19:34 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
2011-02-08 19:34 ` [PATCH 05/12] PTI misc Makefile addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 06/12] PTI header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 07/12] n_tracerouter and n_tracesink additions james_p_freyensee
2011-02-08 19:34 ` [PATCH 08/12] n_tracesink ldisc addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 09/12] n_tracesink header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 10/12] n_tracerouter ldisc driver james_p_freyensee
2011-02-08 19:34 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig james_p_freyensee
2011-02-08 19:34 ` [PATCH 12/12] n_tracerouter and n_tracesink Makefile addition james_p_freyensee
2011-02-08 21:03 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig Randy Dunlap
2011-02-17 19:23 ` [PATCH 09/12] n_tracesink header file Greg KH
2011-02-17 19:45 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:10 ` J Freyensee
2011-02-17 21:43 ` Greg KH
2011-02-22 20:22 ` J Freyensee
2011-02-22 20:26 ` Greg KH
2011-02-22 22:55 ` J Freyensee
2011-02-17 19:21 ` [PATCH 07/12] n_tracerouter and n_tracesink additions Greg KH
2011-02-17 19:43 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:11 ` J Freyensee
2011-02-24 11:52 ` Alan Cox [this message]
2011-02-17 19:20 ` [PATCH 06/12] PTI header file Greg KH
2011-02-17 19:41 ` J Freyensee
2011-02-17 19:55 ` Greg KH
2011-02-17 20:13 ` J Freyensee
2011-02-17 19:20 ` [PATCH 04/12] PTI Kconfig change in misc Greg KH
2011-02-17 19:35 ` J Freyensee
2011-02-17 19:45 ` Greg KH
2011-02-08 20:55 ` [PATCH 02/12] Kernel documentation for the PTI feature Randy Dunlap
2011-02-08 19:38 ` [PATCH 01/12] export kernel call get_task_comm() Christoph Hellwig
2011-02-08 19:44 ` james_p_freyensee
2011-02-08 20:04 ` Christoph Hellwig
2011-02-08 20:35 ` james_p_freyensee
2011-02-08 20:28 ` Alan Cox
2011-02-08 20:28 ` Christoph Hellwig
2011-02-08 20:36 ` Alan Cox
2011-02-15 10:57 ` Christoph Hellwig
2011-02-22 18:38 ` J Freyensee
2011-02-22 18:41 ` Greg KH
2011-02-09 0:17 [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-09 0:17 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-09 0:17 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
2011-02-09 0:17 ` [PATCH 05/12] PTI misc Makefile addition james_p_freyensee
2011-02-09 0:17 ` [PATCH 06/12] PTI header file james_p_freyensee
2011-02-09 0:17 ` [PATCH 07/12] n_tracerouter and n_tracesink additions james_p_freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224115229.3e482bf2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®