From: Grant Likely <grant.likely@secretlab.ca>
To: Dirk Eibach <eibach@gdsys.de>
Cc: linux-kernel@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH v3] gpio: Fix wrong pointer type in pca953x
Date: Thu, 24 Feb 2011 08:56:11 -0700 [thread overview]
Message-ID: <20110224155611.GA17735@angua.secretlab.ca> (raw)
In-Reply-To: <1298539243-25150-1-git-send-email-eibach@gdsys.de>
On Thu, Feb 24, 2011 at 10:20:43AM +0100, Dirk Eibach wrote:
> pca953x_get_alt_pdata() uses uint16_t* as result type for
> of_get_property(), but numeric of values are __be32.
>
> Checking for negative values is bogus because of-property
> values are unsigned by definition.
> Instead check for proper property size.
>
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
Applied, thanks.
g.
prev parent reply other threads:[~2011-02-24 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 8:56 [PATCH] " Dirk Eibach
2011-02-22 12:36 ` Dan Carpenter
2011-02-22 12:52 ` Eibach, Dirk
2011-02-22 13:28 ` [PATCH v2] " Dirk Eibach
2011-02-24 9:20 ` [PATCH v3] " Dirk Eibach
2011-02-24 15:56 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224155611.GA17735@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=eibach@gdsys.de \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®