From: "Henrik Rydberg" <rydberg@euromail.se>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, micki@n-trig.com, chatty@enac.fr,
trivial@kernel.org, peter.hutterer@who-t.net
Subject: Re: [PATCH 1/2] HID: ntrig don't dereference unclaimed hidinput
Date: Sat, 26 Feb 2011 08:36:33 +0100 [thread overview]
Message-ID: <20110226073633.GA1753@polaris.bitmath.org> (raw)
In-Reply-To: <1298610932-21957-1-git-send-email-rafi@seas.upenn.edu>
Hi Rafi,
On Fri, Feb 25, 2011 at 12:15:31AM -0500, Rafi Rubin wrote:
> Moved the claimed input check before dereferencing field->hidinput to
> fix a reported invalid deference bug.
How long has this problem been seen? If it is recent, it should
perhaps be fixed in the hid core instead. If it turns out to be an old
problem, please add stable to the Cc.
> Switched to a goto instead of an extra indent for most of the function.
If you put these janitory changes into a separate patch, it will be
much easier to apply the bugfix to stable versions.
Thanks,
Henrik
next prev parent reply other threads:[~2011-02-26 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 5:15 Rafi Rubin
2011-02-25 5:15 ` [PATCH 2/2] HID: ntrig mapping more firmware id bits Rafi Rubin
2011-02-28 9:07 ` Jiri Kosina
2011-02-26 7:36 ` Henrik Rydberg [this message]
2011-02-26 7:50 ` [PATCH 1/2] HID: ntrig don't dereference unclaimed hidinput Rafi Rubin
2011-02-27 22:17 ` Peter Hutterer
2011-02-26 10:58 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226073633.GA1753@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=peter.hutterer@who-t.net \
--cc=rafi@seas.upenn.edu \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®