From: Tejun Heo <tj@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86,mm,64bit: Round up memory boundary for init_memory_mapping_high()
Date: Sat, 26 Feb 2011 11:55:20 +0100 [thread overview]
Message-ID: <20110226105520.GA9700@htj.dyndns.org> (raw)
In-Reply-To: <20110226103616.GA8701@htj.dyndns.org>
On Sat, Feb 26, 2011 at 11:36:16AM +0100, Tejun Heo wrote:
> On Fri, Feb 25, 2011 at 07:08:40PM -0800, Yinghai Lu wrote:
> > + end_pfn = round_up(end_pfn, data->align>>PAGE_SHIFT);
>
> And now you're mapping beyond max_pfn without even noting the behavior
> change _anywhere_. What the hell? It's not like this point hasn't
> been brought up before. It has been mentioned _twice_ in this very
> thread. Come on.
Reading the code again, the range is capped by
mapping_work_data->start/end, so it won't go over max_pfn. I
apologize for the unwarranted rant about this part, but unfortunately
the rest of the complaints still stand.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-02-26 10:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 17:19 questions about init_memory_mapping_high() Tejun Heo
2011-02-23 20:24 ` Yinghai Lu
2011-02-23 20:46 ` Tejun Heo
2011-02-23 20:51 ` Yinghai Lu
2011-02-23 21:03 ` Tejun Heo
2011-02-23 22:17 ` Yinghai Lu
2011-02-24 9:15 ` Tejun Heo
2011-02-25 1:37 ` Yinghai Lu
2011-02-25 1:38 ` [PATCH 1/2] x86,mm: Introduce init_memory_mapping_ext() Yinghai Lu
2011-02-25 6:20 ` [PATCH 2/2] x86,mm,64bit: Round up memory boundary for init_memory_mapping_high() Yinghai Lu
2011-02-25 10:03 ` Ingo Molnar
2011-02-25 20:22 ` Yinghai Lu
2011-02-26 3:06 ` [PATCH 1/3] x86, mm: Introduce global page_size_mask Yinghai Lu
2011-02-26 3:07 ` [PATCH 2/3] x86,mm: Introduce init_memory_mapping_ext() Yinghai Lu
2011-02-26 3:08 ` [PATCH 3/3] x86,mm,64bit: Round up memory boundary for init_memory_mapping_high() Yinghai Lu
2011-02-26 10:36 ` Tejun Heo
2011-02-26 10:55 ` Tejun Heo [this message]
2011-02-25 11:16 ` [PATCH 2/2] " Tejun Heo
2011-02-25 20:18 ` Yinghai Lu
2011-02-26 8:57 ` Tejun Heo
2011-02-27 11:53 ` Ingo Molnar
2011-02-28 18:14 ` questions about init_memory_mapping_high() H. Peter Anvin
2011-03-01 8:29 ` Tejun Heo
2011-03-01 19:44 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226105520.GA9700@htj.dyndns.org \
--to=tj@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®