From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755945Ab1CBKHi (ORCPT ); Wed, 2 Mar 2011 05:07:38 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:59050 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756233Ab1CBKHh (ORCPT ); Wed, 2 Mar 2011 05:07:37 -0500 Date: Wed, 2 Mar 2011 11:07:27 +0100 From: Ingo Molnar To: Tejun Heo Cc: David Rientjes , Yinghai Lu , tglx@linutronix.de, "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH x86/mm] x86-64, NUMA: Fix distance table handling Message-ID: <20110302100727.GA24692@elte.hu> References: <20110224145128.GM7840@htj.dyndns.org> <4D66AC9C.6080500@kernel.org> <20110224192305.GB15498@elte.hu> <4D66B176.9030300@kernel.org> <20110302100400.GK19669@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110302100400.GK19669@htj.dyndns.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tejun Heo wrote: > + size_t size = numa_distance_cnt * numa_distance_cnt * > + sizeof(numa_distance[0]); > + memblock_x86_reserve_range(phys, phys + phys_size, > + "TMP NUMA DIST"); > + memblock_x86_free_range(__pa(phys_dist), > + __pa(phys_dist) + phys_size); These silly linebreaks are really annoying. Please ignore checkpatch when the solution makes the result so much uglier. Having line width up to 90-95 is still fine. Thanks, Ingo