From: Wolfram Sang <w.sang@pengutronix.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Dirk Eibach <eibach@gdsys.de>,
linux-kernel@vger.kernel.org, guenter.roeck@ericsson.com,
lm-sensors@lm-sensors.org, rdunlap@xenotime.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015
Date: Wed, 2 Mar 2011 19:16:51 +0100 [thread overview]
Message-ID: <20110302181651.GA24054@pengutronix.de> (raw)
In-Reply-To: <20110302185718.3c0e06dc@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
> > +#ifdef CONFIG_OF
> > + /* fallback on OF */
> > + of_channels = of_get_property(np, "exported-channels",
> > + &of_channels_size);
> > + if (of_channels && (of_channels_size == sizeof(*of_channels)))
> > + return be32_to_cpup(of_channels);
> > +#endif
>
> The be32 thing looks odd. I don't get the idea, but as I don't know
> much about devicetree, I'll trust you.
That's okay. The properties are be32 (coming from powerpc).
Still, there is a new property defined which _always_ needs
a) CCing devicetree-discuss (get_maintainer helps here)
b) Documentation in Documentation/devicetree/bindings
because it needs to be a lot more stable than platform_data.
(I already lost the original mail, so I sadly can't forward it)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-03-02 18:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 9:26 [PATCH] " Dirk Eibach
2011-02-14 10:22 ` Jean Delvare
2011-02-14 13:21 ` [PATCH v2] " Dirk Eibach
2011-02-16 4:50 ` Guenter Roeck
2011-02-17 12:17 ` Jean Delvare
2011-02-17 12:42 ` Jean Delvare
2011-02-18 10:15 ` [PATCH v3] " Dirk Eibach
2011-02-24 16:48 ` Jean Delvare
2011-02-25 13:18 ` [PATCH v4] " Dirk Eibach
2011-03-02 17:57 ` Jean Delvare
2011-03-02 18:16 ` Wolfram Sang [this message]
2011-03-03 7:49 ` (WARNING!!! PGP with incorrect signature) " Eibach, Dirk
2011-03-03 7:56 ` Jean Delvare
2011-03-03 7:53 ` Eibach, Dirk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302181651.GA24054@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=eibach@gdsys.de \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®