mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Engel <david@istwok.net>
To: Greg KH <gregkh@suse.de>
Cc: Stefan Bader <stefan.bader@canonical.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, stable@kernel.org, lwn@lwn.net
Subject: Re: Linux 2.6.32.30
Date: Wed, 2 Mar 2011 16:29:35 -0600	[thread overview]
Message-ID: <20110302222935.GA21539@opus.istwok.net> (raw)
In-Reply-To: <20110302204202.GB19022@suse.de>

On Wed, Mar 02, 2011 at 03:42:02PM -0500, Greg KH wrote:
> On Wed, Mar 02, 2011 at 05:50:16PM +0100, Stefan Bader wrote:
> > > FUJITA Tomonori (1):
> > >       swiotlb: fix wrong panic
> > >
> > 
> > This one breaks compilation of 64bit for me as swiotlb_tbl_unmap_single() does
> > not exist. It does not look like it is a simple single patch that would get it
> > back to 2.6.32.
> 
> I don't understand.  Is this patch somehow broken?  Is there an
> additional patch I need to apply to fix the build issue?  I need more
> information here.

I think this will fix it.

Fix compilation error introduced in 484d82b6.

do_unmap_single() was renamed to swiotlb_tbl_unmap_single() in
bfc5501f.  Use the old name unless/until that change is also
backported.

Signed-off-by: David Engel <david@istwok.net>

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 7740ee8..0d0df11 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -632,7 +632,7 @@ dma_addr_t swiotlb_map_page(struct device *dev, struct page *page,
 	 * Ensure that the address returned is DMA'ble
 	 */
 	if (!dma_capable(dev, dev_addr, size)) {
-		swiotlb_tbl_unmap_single(dev, map, size, dir);
+		do_unmap_single(dev, map, size, dir);
 		dev_addr = swiotlb_virt_to_bus(dev, io_tlb_overflow_buffer);
 	}
 
David
-- 
David Engel
david@istwok.net

      parent reply	other threads:[~2011-03-02 22:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 14:58 Greg KH
2011-03-02 15:00 ` Greg KH
2011-03-02 16:50 ` Stefan Bader
2011-03-02 20:42   ` Greg KH
2011-03-02 22:17     ` Stefan Bader
2011-03-02 22:24     ` Shawn Bohrer
2011-03-02 22:29     ` David Engel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302222935.GA21539@opus.istwok.net \
    --to=david@istwok.net \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=stable@kernel.org \
    --cc=stefan.bader@canonical.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®