From: Grant Likely <grant.likely@secretlab.ca>
To: Roland Stigge <stigge@antcom.de>
Cc: linux-kernel@vger.kernel.org, info@pengutronix.de
Subject: Re: [PATCH] max730x: Added setup/teardown hooks
Date: Thu, 3 Mar 2011 12:37:05 -0700 [thread overview]
Message-ID: <20110303193705.GA10391@angua.secretlab.ca> (raw)
In-Reply-To: <4D6FEB74.7050503@antcom.de>
On Thu, Mar 03, 2011 at 08:26:44PM +0100, Roland Stigge wrote:
> On 03/03/2011 07:59 PM, Grant Likely wrote:
> > On Fri, Feb 11, 2011 at 5:00 AM, <stigge@antcom.de> wrote:
> >> max730x: Added setup/teardown hooks
> >>
> >> This patch adds setup and teardown hooks for configuration of GPIO lines via
> >> platform_data, similar to the pca953x driver.
> >
> > Why? What actions are these hooks going to perform?
>
> In board configurations, ARM systems are set up with GPIO lines
> configured as Input or Output etc. See also arch/arm/*/*. See usage of
> pca953x - how it is already done there.
It appears to simply be notifying the platform code that the gpio chip
has been registered. My point is that it doesn't seem to make any
sense whatsoever to have driver specific hooks to inform platform code
that a gpio controller has shown up. It is something that should be
part of the infrastructure. I would much rather see this get
implemented with a notifier or something similar in gpiochip_add().
Other drivers may currently be doing driver-specific callbacks, but it
is a bad pattern and I don't want any more drivers to do so.
g.
prev parent reply other threads:[~2011-03-03 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 12:00 stigge
2011-03-03 18:59 ` Grant Likely
2011-03-03 19:26 ` Roland Stigge
2011-03-03 19:37 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303193705.GA10391@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=info@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®