From: Richard Cochran <richardcochran@gmail.com>
To: Torben Hohn <torbenh@gmx.de>
Cc: linux-kernel@vger.kernel.org, richard.cochran@omicron.at,
johnstul@us.ibm.com, tglx@linutronix.de
Subject: Re: [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw
Date: Fri, 4 Mar 2011 07:42:51 +0100 [thread overview]
Message-ID: <20110304064251.GC3824@riccoc20.at.omicron.at> (raw)
In-Reply-To: <1299173174-348-3-git-send-email-torbenh@gmx.de>
On Thu, Mar 03, 2011 at 06:26:13PM +0100, Torben Hohn wrote:
> +config PTP_1588_CLOCK_SOFTWARE
> + tristate "software PTP clock"
> + depends on PTP_1588_CLOCK
> + help
> + This driver adds a software PTP clock.
As John said, this needs a longer description. You can look back at
my V6 as an example.
https://lkml.org/lkml/2010/9/23/220
> +static int ptp_ixp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
Once again, please rename.
Better yet, why not just use the V6 example instead? If we are going
to have a testing driver, then I would want the simulated ancillary
code as well.
> +
> +static struct ptp_clock_info ptp_ixp_caps = {
> + .owner = THIS_MODULE,
> + .name = "software timer",
> + .max_adj = 66666655,
You should calculate the actual limit of adjustment and use it here.
Thanks,
Richard
next prev parent reply other threads:[~2011-03-04 6:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 17:26 some patches for the ptp framework Torben Hohn
2011-03-03 17:26 ` [PATCH 1/3] remove __cpuinit from mwait_usable() Torben Hohn
2011-03-03 17:26 ` [PATCH 2/3] ptp: add a software clock based on clock_monotonic_raw Torben Hohn
2011-03-03 19:34 ` john stultz
2011-03-04 6:46 ` Richard Cochran
2011-03-04 11:06 ` torbenh
2011-03-05 20:08 ` john stultz
2011-03-06 13:28 ` Richard Cochran
2011-03-11 11:13 ` torbenh
2011-03-11 11:37 ` Christian Riesch
2011-03-11 13:38 ` torbenh
2011-03-11 11:56 ` Christian Riesch
2011-03-04 6:42 ` Richard Cochran [this message]
2011-03-04 11:30 ` torbenh
2011-03-04 16:10 ` Richard Cochran
2011-03-03 17:26 ` [PATCH 3/3] Check for write permission on FD based posix-clocks Torben Hohn
2011-03-04 7:22 ` Richard Cochran
2011-03-04 9:55 ` Arnd Bergmann
2011-03-04 10:13 ` torbenh
2011-03-11 19:46 ` Thomas Gleixner
2011-03-12 17:23 ` Richard Cochran
2011-03-12 17:35 ` Thomas Gleixner
2011-03-12 20:30 ` [tip:timers/core] posix-clocks: Check write permissions in posix syscalls tip-bot for Torben Hohn
2011-03-04 6:21 ` some patches for the ptp framework Richard Cochran
2011-03-10 7:02 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304064251.GC3824@riccoc20.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.cochran@omicron.at \
--cc=tglx@linutronix.de \
--cc=torbenh@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®