Re: [PATCH 2/2] PCI: do not create quirk I/O regions below PCIBIOS_MIN_IO for ICH

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Mon, 28 Feb 2011 10:45:10 +0100
Jiri Slaby <jslaby@suse.cz> wrote:

> Some broken BIOSes on ICH4 chipset report an ACPI region which is in
> conflict with legacy IDE ports when ACPI is disabled. Even though the
> regions overlap, IDE ports are working correctly (we cannot find out
> the decoding rules on chipsets).
> 
> So the only problem is the reported region itself, if we don't reserve
> the region in the quirk everything works as expected.
> 
> This patch avoids reserving any quirk regions below PCIBIOS_MIN_IO
> which is 0x1000. Some regions might be (and are by a fast google
> query) below this border, but the only difference is that they won't
> be reserved anymore. They should still work though the same as before.
> 
> The conflicts look like (1f.0 is bridge, 1f.1 is IDE ctrl):
> pci 0000:00:1f.1: address space collision: [io 0x0170-0x0177] conflicts with 0000:00:1f.0 [io  0x0100-0x017f]
> 
> At 0x0100 a 128 bytes long ACPI region is reported in the quirk for
> ICH4. ata_piix then fails to find disks because the IDE legacy ports
> are zeroed:
> ata_piix 0000:00:1f.1: device not available (can't reserve [io 0x0000-0x0007])

Applied both of these, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center