mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: stable@kernel.org
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, anton@samba.org,
	benh@kernel.crashing.org
Subject: [PATCH 2/7] powerpc/kdump: Use chip->shutdown to disable IRQs
Date: Mon, 7 Mar 2011 17:16:37 +0530	[thread overview]
Message-ID: <20110307114637.GD8194@linux.vnet.ibm.com> (raw)

    powerpc/kdump: Use chip->shutdown to disable IRQs

    Commit: 5d7a87217de48b234b3c8ff8a73059947d822e07 upstream

    I saw this in a kdump kernel:

    IOMMU table initialized, virtual merging enabled
    Interrupt 155954 (real) is invalid, disabling it.
    Interrupt 155953 (real) is invalid, disabling it.

    ie we took some spurious interrupts. default_machine_crash_shutdown tries
    to disable all interrupt sources but uses chip->disable which maps to
    the default action of:

    static void default_disable(unsigned int irq)
    {
    }

    If we use chip->shutdown, then we actually mask the IRQ:

    static void default_shutdown(unsigned int irq)
    {
            struct irq_desc *desc = irq_to_desc(irq);

            desc->chip->mask(irq);
            desc->status |= IRQ_MASKED;
    }

    Not sure why we don't implement a ->disable action for xics.c, or why
    default_disable doesn't mask the interrupt.

    Signed-off-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Kamalesh babulal <kamalesh@linux.vnet.ibm.com>
---
 arch/powerpc/kernel/crash.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/powerpc/kernel/crash.c
===================================================================
--- a/arch/powerpc/kernel/crash.c	2011-03-07 00:27:22.703086492 -0800
+++ b/arch/powerpc/kernel/crash.c	2011-03-07 00:27:49.659105563 -0800
@@ -382,7 +382,7 @@
			desc->chip->eoi(i);

		if (!(desc->status & IRQ_DISABLED))
-			desc->chip->disable(i);
+			desc->chip->shutdown(i);
	}

	/*


                 reply	other threads:[~2011-03-07 11:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110307114637.GD8194@linux.vnet.ibm.com \
    --to=kamalesh@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome