From: Herbert Xu <herbert@gondor.hengli.com.au>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: James.Bottomley@hansenpartnership.com, hch@infradead.org,
rdunlap@xenotime.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level
Date: Tue, 8 Mar 2011 17:33:34 +0800 [thread overview]
Message-ID: <20110308093334.GA21996@gondor.apana.org.au> (raw)
In-Reply-To: <1299539747.19683.333.camel@haakon2.linux-iscsi.org>
Nicholas A. Bellinger <nab@linux-iscsi.org> wrote:
>
>> > I should mention this is with the following .config:
>> >
>> > CONFIG_CRYPTO_CRC32C=y
>> > CONFIG_CRYPTO_CRC32C_INTEL=m
This is why you get the unoptimised version. Had you selected
both as built-in or both as modules, then it would have worked
as intended.
> What about the following to simply call request_module("crc32c_intel")
> at module_init() time and top the extra iscsi_login_setup_crypto()
> code..?
If we're going to do this we should do it in the crypto layer,
and not litter every single crypto API user with such crap.
Currently we don't invoke request_module unless no implementation
is reigstered for an algorithm. You can change this so that it
also invokes request_module if we have not yet done so at least
once for that algorithm.
Patches are welcome.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2011-03-08 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 3:33 [RFC 00/12] iSCSI target v4.1.0-rc1 series Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 02/12] iscsi-target: Add primary iSCSI request/response state machine logic Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 03/12] iscsi-target: Add TCM v4 compatiable ConfigFS control plane Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 04/12] iscsi-target: Add configfs fabric dependent statistics Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 05/12] iscsi-target: Add TPG and Device logic Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 06/12] iscsi-target: Add iSCSI Login Negotiation and Parameter logic Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 07/12] iscsi-target: Add CHAP Authentication support using libcrypto Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 08/12] iscsi-target: Add Sequence/PDU list + DataIN response logic Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 09/12] iscsi-target: Add iSCSI Error Recovery Hierarchy support Nicholas A. Bellinger
2011-03-02 3:33 ` [RFC 10/12] iscsi-target: Add support for task management operations Nicholas A. Bellinger
2011-03-02 3:34 ` [RFC 11/12] iscsi-target: Add misc utility and debug logic Nicholas A. Bellinger
2011-03-02 3:34 ` [RFC 12/12] iscsi-target: Add Makefile/Kconfig and update TCM top level Nicholas A. Bellinger
2011-03-02 6:32 ` Randy Dunlap
2011-03-02 21:32 ` Nicholas A. Bellinger
2011-03-02 22:45 ` Randy Dunlap
2011-03-02 23:18 ` Nicholas A. Bellinger
2011-03-03 14:19 ` Christoph Hellwig
2011-03-03 20:58 ` Nicholas A. Bellinger
2011-03-04 17:00 ` James Bottomley
2011-03-07 23:15 ` Nicholas A. Bellinger
2011-03-08 9:33 ` Herbert Xu [this message]
2011-03-10 8:02 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308093334.GA21996@gondor.apana.org.au \
--to=herbert@gondor.hengli.com.au \
--cc=James.Bottomley@hansenpartnership.com \
--cc=hch@infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®