Re: [PATCHv3 1/1] sysfs: add more info to the oops dump

[Phil Carmody <ext-phil.2.carmody@nokia.com>]

On 11/03/11 00:13 +0100, ext Thomas Gleixner wrote:
> On Fri, 11 Mar 2011, Phil Carmody wrote:
> > On 10/03/11 23:59 +0100, ext Thomas Gleixner wrote:
> > > On Thu, 10 Mar 2011, Andrew Morton wrote:
...
> > > > I don't think it's a terribly useful feature.  Except for when it _is_
> > > > useful, when it's very useful ;) The world wouldn't end if we decided
> > > > to remove it.
> > > 
> > > Amen to that.
> > > 
> > > It's more of an distraction than anything which is relevant to 99.999%
> > > of the problems we have to deal with.
> > 
> > As I indicated before, I've previously thought that too, but thought I
> > could 'fix' it by adding to it when I hit the once-in-three-years case.
> 
> The interesting question is:
> 
>  How did that info help and was it really the ultimate reason why you
>  found the underlying bug ?

It's academic now, as I fully support the removal. Perhaps the information
was most useful simply because it was given to me quickly, there would have
been other ways of divining it certainly (I can read hex stack dumps, for
example). Even I don't need this patch any more!

At least my intrusion has been useful for instigating a little cleanup!

Cheers,
Phil