mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: axboe@kernel.dk
Cc: mikem@beardog.cce.hp.com, akpm@linux-foundation.org,
	thenzl@redhat.com, linux-kernel@vger.kernel.org,
	smcameron@yahoo.com
Subject: [PATCH 1/7] cciss: hoist tag masking out of loop
Date: Fri, 11 Mar 2011 14:55:35 -0600	[thread overview]
Message-ID: <20110311205535.2211.20855.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20110311205306.2211.53569.stgit@beardog.cce.hp.com>

From: Stephen M. Cameron <scameron@beardog.cce.hp.com>

In process_nonindexed_cmd, hoist figuring of masked tag out of loop since
it is the same throughout.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
 drivers/block/cciss.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 35658f4..8c88944 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -3394,14 +3394,12 @@ static inline u32 process_indexed_cmd(ctlr_info_t *h, u32 raw_tag)
 /* process completion of a non-indexed command */
 static inline u32 process_nonindexed_cmd(ctlr_info_t *h, u32 raw_tag)
 {
-	u32 tag;
 	CommandList_struct *c = NULL;
 	__u32 busaddr_masked, tag_masked;
 
-	tag = cciss_tag_discard_error_bits(raw_tag);
+	tag_masked = cciss_tag_discard_error_bits(raw_tag);
 	list_for_each_entry(c, &h->cmpQ, list) {
 		busaddr_masked = cciss_tag_discard_error_bits(c->busaddr);
-		tag_masked = cciss_tag_discard_error_bits(tag);
 		if (busaddr_masked == tag_masked) {
 			finish_cmd(h, c, raw_tag);
 			return next_command(h);


  reply	other threads:[~2011-03-11 20:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 20:55 [PATCH 0/7] cciss: updates as of March 11, 2011 Stephen M. Cameron
2011-03-11 20:55 ` Stephen M. Cameron [this message]
2011-03-11 20:55 ` [PATCH 2/7] cciss: Inform controller we are using 32-bit tags Stephen M. Cameron
2011-03-11 20:55 ` [PATCH 3/7] cciss: Mask off error bits of c->busaddr in cmd_special_free when calling pci_free_consistent Stephen M. Cameron
2011-03-11 20:55 ` [PATCH 4/7] cciss: remove unnecessary casts Stephen M. Cameron
2011-03-11 20:55 ` [PATCH 5/7] cciss: fix missed command status value CMD_UNABORTABLE Stephen M. Cameron
2011-03-11 20:56 ` [PATCH 6/7] cciss: add cciss_tape_cmds module paramter Stephen M. Cameron
2011-03-11 20:56 ` [PATCH 7/7] cciss: export resettable host attribute Stephen M. Cameron
2011-03-12  9:03 ` [PATCH 0/7] cciss: updates as of March 11, 2011 Jens Axboe
2011-03-14 16:37   ` scameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110311205535.2211.20855.stgit@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikem@beardog.cce.hp.com \
    --cc=smcameron@yahoo.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome