From: Steven Rostedt <rostedt@goodmis.org>
To: Justin TerAvest <teravest@google.com>
Cc: jaxboe@fusionio.com, vgoyal@redhat.com, ctalbott@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add unaccounted time to timeslice_used.
Date: Fri, 11 Mar 2011 23:17:29 -0500 [thread overview]
Message-ID: <20110312041729.GB15526@home.goodmis.org> (raw)
In-Reply-To: <1299877572-30353-1-git-send-email-teravest@google.com>
On Fri, Mar 11, 2011 at 01:06:12PM -0800, Justin TerAvest wrote:
> There are two kind of times that tasks are not charged for: the first
> seek and the extra time slice used over the allocated timeslice. Both
> of these exported as a new unaccounted_time stat.
>
> I think it would be good to have this reported in 'time' as well, but
> that is probably a separate discussion.
>
> Signed-off-by: Justin TerAvest <teravest@google.com>
> ---
> block/blk-cgroup.c | 16 +++++++++++++++-
> block/blk-cgroup.h | 12 ++++++++++--
> block/cfq-iosched.c | 21 +++++++++++++--------
> block/cfq.h | 6 +++---
> 4 files changed, 41 insertions(+), 14 deletions(-)
Hi! Just an FYI, could you add what subsystem you are changing into the
subject. Like:
[PATCH] block: Add unaccounted time to timeslice_used
Otherwise, the subject looks like it's modifying the kernel internal time
source.
Thanks,
-- Steve
next prev parent reply other threads:[~2011-03-12 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 21:06 Justin TerAvest
2011-03-12 4:17 ` Steven Rostedt [this message]
2011-03-12 5:35 ` Justin TerAvest
2011-03-12 15:49 ` Jens Axboe
2011-03-14 13:55 ` Vivek Goyal
2011-03-14 21:55 ` Justin TerAvest
2011-03-14 22:11 ` Vivek Goyal
2011-03-22 17:33 ` Vivek Goyal
[not found] ` <AANLkTinV+CjC-wbbm5gHfJxz8Cgh2DXLATY8Jo-1PunX@mail.gmail.com>
2011-03-22 17:48 ` Vivek Goyal
2011-03-22 17:50 ` Justin TerAvest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312041729.GB15526@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=ctalbott@google.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®