From: Grant Likely <grant.likely@secretlab.ca>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2-RESEND] mcp23s08: support mcp23s17 variant
Date: Sat, 12 Mar 2011 01:29:06 -0700 [thread overview]
Message-ID: <20110312082906.GC9347@angua.secretlab.ca> (raw)
In-Reply-To: <1299689790-11426-1-git-send-email-jacmet@sunsite.dk>
On Wed, Mar 09, 2011 at 05:56:30PM +0100, Peter Korsgaard wrote:
> mpc23s17 is very similar to the mcp23s08, except that registers are 16bit
> wide, so extend the interface to work with both variants.
>
> The s17 variant also has an additional address pin, so adjust platform
> data structure to support up to 8 devices per SPI chipselect.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Merged, thanks.
g.
> ---
> Resend without any changes since v2 on Feb 15th.
>
> Changes since v1:
> - Add mcp23s08_ops callbacks for 8 and 16 bit instead of handling both
> in the same accessor function as requested by Grant.
> - Don't use a temporary buffer for 8bit version of read_regs -
> Stack addresses are not DMA safe.
>
> drivers/gpio/Kconfig | 6 +-
> drivers/gpio/mcp23s08.c | 191 +++++++++++++++++++++++++++++++-----------
> include/linux/spi/mcp23s08.h | 15 ++--
> 3 files changed, 155 insertions(+), 57 deletions(-)
>
prev parent reply other threads:[~2011-03-12 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 16:56 Peter Korsgaard
2011-03-12 8:29 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312082906.GC9347@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=dbrownell@users.sourceforge.net \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®