From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] genksyms: Track changes to enum constant
Date: Sun, 13 Mar 2011 08:19:02 +0100 [thread overview]
Message-ID: <20110313071902.GA3377@merkur.ravnborg.org> (raw)
In-Reply-To: <1299997825-18977-1-git-send-email-mmarek@suse.cz>
Hi Michal.
Patch serie looks good.
You can add my ack to all of them if you do a second round.
On Sun, Mar 13, 2011 at 07:30:18AM +0100, Michal Marek wrote:
> This series makes genksyms remember the values of enum constants and use them
> during symbol expansion. This makes sure that patches like
>
> | enum e {
> | E1,
> | E2,
> |+ E3,
> | E_MAX
> | };
> |
> | struct s {
> | int a[E_MAX];
> | }
> |
> | int f(struct s *s) { ... }
> | EXPORT_SYMBOL(f)
>
> change the checksum of the exported symbol. Previously, it would just use the
> string "E_MAX" in the calculation and the change would go unnoticed. The main
> part is in patches 6/7 and 7/7, the rest are cleanups and preparatory patches.
This nice explanation would be good to include in the changelog
of 7/8 so "git log" give a better intro to the changes.
Sam
next prev parent reply other threads:[~2011-03-13 7:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 6:30 Michal Marek
2011-03-13 6:30 ` [PATCH 1/7] genksyms: Do not paste the bison header file to lex.c Michal Marek
2011-03-13 6:30 ` [PATCH 2/7] genksyms: Simplify lexer Michal Marek
2011-03-13 6:30 ` [PATCH 3/7] genksyms: Simplify printing of symbol types Michal Marek
2011-03-13 6:30 ` [PATCH 4/7] genksyms: Add helpers for building string lists Michal Marek
2011-03-13 6:30 ` [PATCH 5/7] genksyms: simplify usage of find_symbol() Michal Marek
2011-03-13 6:30 ` [PATCH 6/7] genksyms: Track changes to enum constants Michal Marek
2011-03-13 6:30 ` [PATCH 7/7] genksyms: Regenerate lexer and parser Michal Marek
2011-03-13 7:19 ` Sam Ravnborg [this message]
2011-03-13 13:40 ` [PATCH 0/7] genksyms: Track changes to enum constant Michal Marek
2011-03-17 14:18 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313071902.GA3377@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®